Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751507AbWBQPwQ (ORCPT ); Fri, 17 Feb 2006 10:52:16 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751508AbWBQPwP (ORCPT ); Fri, 17 Feb 2006 10:52:15 -0500 Received: from e4.ny.us.ibm.com ([32.97.182.144]:16567 "EHLO e4.ny.us.ibm.com") by vger.kernel.org with ESMTP id S1751507AbWBQPwO (ORCPT ); Fri, 17 Feb 2006 10:52:14 -0500 Subject: Re: [PATCH: 005/012] Memory hotplug for new nodes v.2.(pgdat alloc caller for x86-64) From: Dave Hansen To: Yasunori Goto Cc: Andrew Morton , "Luck, Tony" , Andi Kleen , "Tolentino, Matthew E" , Joel Schopp , linux-ia64@vger.kernel.org, Linux Kernel ML , x86-64 Discuss In-Reply-To: <20060217211729.4072.Y-GOTO@jp.fujitsu.com> References: <20060217211729.4072.Y-GOTO@jp.fujitsu.com> Content-Type: text/plain Date: Fri, 17 Feb 2006 07:51:37 -0800 Message-Id: <1140191497.21383.77.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.4.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 622 Lines: 21 On Fri, 2006-02-17 at 22:29 +0900, Yasunori Goto wrote: > + zone_type = start_pfn < MAX_DMA32_PFN ? > + ZONE_DMA32 : ZONE_NORMAL; Please change this to something which we can more easily parse, such as this: if (start_pfn < MAX_DMA32_PFN) zone_type = ZONE_DMA32; else zone_type = ZONE_NORMAL; I think it is worth the extra two lines. -- Dave - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/