Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp905917ybh; Wed, 11 Mar 2020 13:15:03 -0700 (PDT) X-Google-Smtp-Source: ADFU+vvMoIq4Tgmys0QrIgk8Ql5RPiFDdddqfLphcDad0pnrz0SdJJft/+EptiFHl2m51bBVkg/K X-Received: by 2002:a9d:1a4:: with SMTP id e33mr3617203ote.343.1583957703730; Wed, 11 Mar 2020 13:15:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1583957703; cv=none; d=google.com; s=arc-20160816; b=PYns5VWAVWwdhbDxOzyedeAVyvbGMtZ9BkmnM/knz4VUXFk9kq2BM2dGe3gGlzuOQF 3RjNiBZBOwn1bkXAj7Wr3xW1bOLYLR+z4Tbbm8um2nWeB7Ob9H2EGIxwjtdO0Kv2g9Lr 9EaqwwiIQA7fosC0y6sDS4HejjdeByg87g2ItDcpe3GBCuw0fJi1E4xWm/U5p4640zf7 ylTt+rlGaVyTf5Zi8S1mB9h0IvNGASEJuqfYM0N44eo14kpaiYIiaVTE9YPsXtKW1Yam XQsrs770RFDCUYywDmc38zFvWCXMf0rAptJYtNYID6ejOsWmD2VZ5bXJUIGDLXJZMGMq CIzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature:dkim-filter; bh=UgsI4L/7hhHUm8L3XjDdMOn1HtPURuk7s+u4j4PE49E=; b=LpmOQTTf0MbHChDU4Ul4Ce3EoJnngHqYw5YKuwYumW2MSSwCl38DqcB0KD/AfDW5YA OOE7nIp8lXGFdpuhox9mVhHKYt3ItwXan54QolSjjpQbimlk55iQpj7eoFTJ0A3pmFzM WK3muwnFSOe4hwDk3ZeAsY1XryTjSu9ubeLgVK0R5osxXROjNWXfFeSK430niBdmV4FL iKCgstUZsk90eE3iapskKanoOa1l1ycFngAO0TxaAmdLhh5DS67J+JcTC7WX1DSRuN1o WVNcaVT8nUmiZkX/Uc9zfGDSXzS6aT9B3RFtxhQE+IsqqvDISQoO3eZJx9JGh8ukyXu4 K6/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=qeszQ2FU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m24si619693oop.19.2020.03.11.13.14.49; Wed, 11 Mar 2020 13:15:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=qeszQ2FU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731097AbgCKUNY (ORCPT + 99 others); Wed, 11 Mar 2020 16:13:24 -0400 Received: from conssluserg-03.nifty.com ([210.131.2.82]:44421 "EHLO conssluserg-03.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726947AbgCKUNY (ORCPT ); Wed, 11 Mar 2020 16:13:24 -0400 Received: from mail-vk1-f178.google.com (mail-vk1-f178.google.com [209.85.221.178]) (authenticated) by conssluserg-03.nifty.com with ESMTP id 02BKD4v4025297 for ; Thu, 12 Mar 2020 05:13:05 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-03.nifty.com 02BKD4v4025297 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1583957585; bh=UgsI4L/7hhHUm8L3XjDdMOn1HtPURuk7s+u4j4PE49E=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=qeszQ2FUXR7/uYcNONbBryhW4NCRyk80atebVbcpk3fC0Mm2nWiuuKyPTJer0ZPBW 6yuswb+EeCl35RdRn2CxTHoMCOkzkGxBFf7q/lXo6LdrZfFp2UrI+6qgSzxZYC1TGG 0WXj/KmlrN3YzTWLVo2NVK3F4TLWhbqjSitrvSbfvrE8oOKa9COOMpLcZkbqXICYKI hcaS3bIv8qRBAWBczjt/AxmVlPfTXhYd+bQ6NLssyW5OkweHrdZwaeTT009QGm5zVU 91NVb0Jy8JLO/68jyTQ9DLQgj0730xGucS7ZfVY+MQPGTUQwFThU5CzAJdBGcu9cPo IqYZeF6QSiTUg== X-Nifty-SrcIP: [209.85.221.178] Received: by mail-vk1-f178.google.com with SMTP id s139so902080vka.13 for ; Wed, 11 Mar 2020 13:13:05 -0700 (PDT) X-Gm-Message-State: ANhLgQ0BewnAvATnLaKCnkWPKexCKi9uZianLGnLOopEKahpd4XN84XB hGjATUUxghaX2M4ZMsU4vY32MvAik7YrBTrOaBQ= X-Received: by 2002:a1f:2f4c:: with SMTP id v73mr3187092vkv.12.1583957584022; Wed, 11 Mar 2020 13:13:04 -0700 (PDT) MIME-Version: 1.0 References: <20200311102217.25170-1-Eugeniy.Paltsev@synopsys.com> In-Reply-To: <20200311102217.25170-1-Eugeniy.Paltsev@synopsys.com> From: Masahiro Yamada Date: Thu, 12 Mar 2020 05:12:28 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] initramfs: restore default compression behaviour To: Eugeniy Paltsev Cc: Linux Kernel Mailing List , arcml , Vineet Gupta , Alexey Brodkin Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Eugeniy. On Wed, Mar 11, 2020 at 7:22 PM Eugeniy Paltsev wrote: > > Even though INITRAMFS_SOURCE kconfig option isn't set in most of > defconfigs it is used (set) extensively by various build systems. > Commit f26661e12765 ("initramfs: make initramfs compression choice > non-optional") has changed default compression mode. Previously we > compress initramfs using available compression algorithm. Now > we don't use any compression at all by default. > It significantly increases the image size in case of build system > chooses embedded initramfs. Initially I faced with this issue while > using buildroot. > > As of today it's not possible to set preferred compression mode > in target defconfig as this option depends on INITRAMFS_SOURCE > being set. > Modification of build systems doesn't look like good option in this > case as it requires to check against kernel version when setting > compression mode. The reason for this is that kconfig options > describing compression mode was renamed (in same patch series) Which commit? I do not remember the renaming of kconfig options with this regard. > so > we are not able to simply enable one option for old and new kernels. > > Given that I propose to use GZIP as default here instead of NO > compression. It should be used only when available but given that > gzip is enabled by default it looks like good enough choice. Another solution would be to move INITRAMFS_COMPRESSION_NONE to the end of the choice menu. The default of the choice menu is the first visible entry. GZIP if RD_GZIP is defined, BZIP2 if RD_BZIP2 is defined ... > Signed-off-by: Eugeniy Paltsev > --- > usr/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/usr/Kconfig b/usr/Kconfig > index bdf5bbd40727..690ef9020819 100644 > --- a/usr/Kconfig > +++ b/usr/Kconfig > @@ -102,6 +102,7 @@ config RD_LZ4 > > choice > prompt "Built-in initramfs compression mode" > + default INITRAMFS_COMPRESSION_GZIP if RD_GZIP > depends on INITRAMFS_SOURCE != "" > help > This option allows you to decide by which algorithm the builtin > -- > 2.21.1 > -- Best Regards Masahiro Yamada