Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 12 Mar 2020 03:58:55 +0530
User-Agent: K-9 Mail for Android
In-Reply-To: <0fed25f914c6f39b024dd3bbc4f11892c40f4a60.camel@perches.com>
References: <20200311133811.2246-1-shreeya.patel23498@gmail.com> <0fed25f914c6f39b024dd3bbc4f11892c40f4a60.camel@perches.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Outreachy kernel] [PATCH] Staging: rtl8723bs: sdio_halinit: Remove unnecessary conditions
To:     Joe Perches <joe@perches.com>, gregkh@linuxfoundation.org,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
        outreachy-kernel@googlegroups.com, sbrivio@redhat.com,
        daniel.baluta@gmail.com, nramas@linux.microsoft.com,
        hverkuil@xs4all.nl, Larry.Finger@lwfinger.net
From:   Shreeya Patel <shreeya.patel23498@gmail.com>
Message-ID: <1CF27D55-EEB4-4A75-B767-A30845BD5E1B@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hey Joe,

On March 11, 2020 10:56:29 PM GMT+05:30, Joe Perches <joe@perches=2Ecom> w=
rote:
>On Wed, 2020-03-11 at 19:08 +0530, Shreeya Patel wrote:
>> Remove if and else conditions since both are leading to the
>> initialization of "valueDMATimeout" and "valueDMAPageCount" with
>> the same value=2E
>
>You might consider removing the
>	/* Timeout value is calculated by 34 / (2^n) */
>comment entirely as it doesn't make much sense=2E
>

You want me to remove the other comments as well?
Since Julia suggested in another email that the comments are not useful if=
 we are removing the condition since they were applied to only one branch (=
 i=2Ee=2E "if" branch )


Thanks

>For what N is "(34 / (2 ^ N))" =3D 6 ?
>
>> diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit=2Ec
>b/drivers/staging/rtl8723bs/hal/sdio_halinit=2Ec
>[]
>> @@ -551,18 +551,11 @@ static void HalRxAggr8723BSdio(struct adapter
>*padapter)
>> =20
>>  	pregistrypriv =3D &padapter->registrypriv;
>> =20
>> -	if (pregistrypriv->wifi_spec) {
>> -		/*  2010=2E04=2E27 hpfan */
>> -		/*  Adjust RxAggrTimeout to close to zero disable RxAggr,
>suggested by designer */
>> -		/*  Timeout value is calculated by 34 / (2^n) */
>> -		valueDMATimeout =3D 0x06;
>> -		valueDMAPageCount =3D 0x06;
>> -	} else {
>> -		/*  20130530, Isaac@SD1 suggest 3 kinds of parameter */
>> -		/*  TX/RX Balance */
>> -		valueDMATimeout =3D 0x06;
>> -		valueDMAPageCount =3D 0x06;
>> -	}
>> +	/*  2010=2E04=2E27 hpfan */
>> +	/*  Adjust RxAggrTimeout to close to zero disable RxAggr, suggested
>by designer */
>> +	/*  Timeout value is calculated by 34 / (2^n) */
>> +	valueDMATimeout =3D 0x06;
>> +	valueDMAPageCount =3D 0x06;

--=20
Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E