Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 12 Mar 2020 04:00:40 +0530
User-Agent: K-9 Mail for Android
In-Reply-To: <20200311180428.6489fe9b@elisabeth>
References: <20200311131742.31068-1-shreeya.patel23498@gmail.com> <20200311180428.6489fe9b@elisabeth>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Outreachy kernel] [PATCH v4] Staging: rtl8188eu: rtw_mlme: Add space around operators
To:     outreachy-kernel@googlegroups.com,
        Stefano Brivio <sbrivio@redhat.com>
CC:     gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org, daniel.baluta@gmail.com,
        nramas@linux.microsoft.com, hverkuil@xs4all.nl,
        Larry.Finger@lwfinger.net
From:   Shreeya Patel <shreeya.patel23498@gmail.com>
Message-ID: <181B01E8-5D92-458F-9C5E-7271333B96F4@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On March 11, 2020 10:34:28 PM GMT+05:30, Stefano Brivio
 <sbrivio@redhat=2Ecom> wrote:

Hey Stefano,

>On Wed, 11 Mar 2020 18:47:42 +0530
>Shreeya Patel <shreeya=2Epatel23498@gmail=2Ecom> wrote:
>
>> Add space around operators for improving the code
>> readability=2E
>> Reported by checkpatch=2Epl
>>=20
>> git diff -w shows no difference=2E
>> diff of the =2Eo files before and after the changes shows no
>difference=2E
>>=20
>> Signed-off-by: Shreeya Patel <shreeya=2Epatel23498@gmail=2Ecom>
>
>This looks good to me=2E Further clean-ups here could probably make this
>look less messy (there are long lines, unnecessary parentheses that are
>rather confusing, especially on that 4/5 factor, "magic" constants that
>might make sense to figure out the meaning of, etc=2E)=2E
>

Thanks for reviewing=2E I will surely look at the other clean-ups as well =
:)

Thanks

>Reviewed-by: Stefano Brivio <sbrivio@redhat=2Ecom>

--=20
Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E