Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp1024446ybh;
        Wed, 11 Mar 2020 15:57:16 -0700 (PDT)
X-Google-Smtp-Source: ADFU+vujYOrpu6ErJdDX+2oIi0TpAHKigv10hS8rEX9fjwIbXQbhayimdVbIRYYiqtZPRHC6k2Mk
X-Received: by 2002:a9d:7d89:: with SMTP id j9mr3834163otn.47.1583967436078;
        Wed, 11 Mar 2020 15:57:16 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1583967436; cv=none;
        d=google.com; s=arc-20160816;
        b=zknRyu28uCFrbQxY7TjdlPaJ1bs/MrhUIvvcPWh6EZ1Y/nfaNpk9bmKPB5eb8r71B+
         /dzRaZ6UhzM8GTKfqFvYTcpv2VcGGDqMt6NMMRQBOgLYpfM/2oJPLBLvrAYCWQl7pO45
         77PHqsUzx6zU8wOpanj1aLd2rdpiUmI9W2q+xLjRBu24Eo/i2CfyZ4J8Dk32BLzr2rN0
         DSTR0944SEqquJ0A4tl9YP8vMXUsuloR+kyWWly9bNXz9al1c/Kd+LvODTdjL/kcezp6
         YEDeJZm3VXDojJt23TLiPWIMAXrsobR0J5aDo1AtxGOc97ruuAPncwNGUU5yQgpMPEMw
         yl9w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding:mime-version
         :references:in-reply-to:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=vVFuak+89eGWfAQ2qp/uNcMpt7Muw79B207Cne/FRn8=;
        b=swTCA1w7NbNscduCvqcF3NBQsGLtKQdQWpdvJuDNsgsp8OLjvwvVsaAt/LnwkP2p5d
         vcxXG2hrVJIhw/CK+/ha7thwdbIJQup7eiyod/FlM5Y1colT4e63JScCt1eFrihTdvFS
         ZXQ5dUta5zFB7sZkit4nJKoev1gmbuDW/ChvTckLoReU0QuPSYelIxVS965E8DkKo7dK
         66q+g7KV2PoKw07nWs9baU0K9DCfkxq5eN6ok9mB5wDEZENXb9hrSmxkESvj8f4vwmjG
         7gmHYZSn1lNcjmd9jgX3Gp1noUQw8JF4VqFQagopE6HAJIgkO9hPxxoMFs0ajpdviEKd
         Ia7w==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=tPnsfiDy;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id n4si1666023oic.213.2020.03.11.15.57.04;
        Wed, 11 Mar 2020 15:57:16 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=tPnsfiDy;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1731438AbgCKW4f (ORCPT <rfc822;hackukernel@gmail.com>
        + 99 others); Wed, 11 Mar 2020 18:56:35 -0400
Received: from mail.kernel.org ([198.145.29.99]:57364 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1731369AbgCKW4f (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 11 Mar 2020 18:56:35 -0400
Received: from kicinski-fedora-PC1C0HJN (unknown [163.114.132.128])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id C7C8520749;
        Wed, 11 Mar 2020 22:56:34 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1583967395;
        bh=0hcCwLr76Y1HrvSf0R8uI0eUyHi0rxL8GhpK18dgQEo=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=tPnsfiDyJsW5WEF+WkzlAvGp57GzDEn/TDYqZBZ3gTLb/qSlNOHKYVHPzTPMBApJ/
         QZa0LyrM9NUFT47l7Q6v/KzMMSW2s+mZuWYC2TINpdwWT1HAN75hWY4PtQ3DjL3SS4
         YSebbhUJmj8KOx68C1iWfC9FpGM/2ZutN18Vx4v4=
Date:   Wed, 11 Mar 2020 15:56:32 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Michal Kubecek <mkubecek@suse.cz>
Cc:     David Miller <davem@davemloft.net>, netdev@vger.kernel.org,
        Jiri Pirko <jiri@resnulli.us>, Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        John Linville <linville@tuxdriver.com>,
        Johannes Berg <johannes@sipsolutions.net>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 05/15] ethtool: set netdev features with
 FEATURES_SET request
Message-ID: <20200311155632.4521c71b@kicinski-fedora-PC1C0HJN>
In-Reply-To: <4fda0f27da984254c3df3c9e58751134967036c9.1583962006.git.mkubecek@suse.cz>
References: <cover.1583962006.git.mkubecek@suse.cz>
        <4fda0f27da984254c3df3c9e58751134967036c9.1583962006.git.mkubecek@suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 11 Mar 2020 22:40:28 +0100 (CET) Michal Kubecek wrote:
> +	if (!(req_info.flags & ETHTOOL_FLAG_OMIT_REPLY)) {
> +		bool compact = req_info.flags & ETHTOOL_FLAG_COMPACT_BITSETS;

is req_info->flags validated anywhere to make sure users get an error
when they set a bit unrecognized by the kernel? :S