Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 12 Mar 2020 03:42:52 +0300
From:   "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
To:     Vlastimil Babka <vbabka@suse.cz>
Cc:     Mike Kravetz <mike.kravetz@oracle.com>,
        Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/hugetlb: remove unnecessary memory fetch in
 PageHeadHuge()
Message-ID: <20200312004252.efb3bfirdk4ghe4z@black.fi.intel.com>
References: <20200311172440.6988-1-vbabka@suse.cz>
 <20200312004119.b7uew2jriwx2mks5@black.fi.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200312004119.b7uew2jriwx2mks5@black.fi.intel.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Mar 12, 2020 at 03:41:19AM +0300, Kirill A. Shutemov wrote:
> On Wed, Mar 11, 2020 at 06:24:40PM +0100, Vlastimil Babka wrote:
> > Commit f1e61557f023 ("mm: pack compound_dtor and compound_order into one word
> > in struct page") changed compound_dtor from a pointer to an array index in
> > order to pack it. To check if page has the hugeltbfs compound_dtor, we can
> > just compare the index directly without fetching the function pointer.
> > Said commit did that with PageHuge() and we can do the same with PageHeadHuge()
> > to make the code a bit smaller and faster.
> > 
> > Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
> > Cc: Mike Kravetz <mike.kravetz@oracle.com>
> > Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> 
> Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> 
> We use literaly the same check in the function next to this one --
> PageHuge().

Ugh.. I have to read the commit message, not only the code :P

-- 
 Kirill A. Shutemov