Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 12 Mar 2020 01:49:10 +0000
From:   Ashish Kalra <ashish.kalra@amd.com>
To:     Steve Rutherford <srutherford@google.com>
Cc:     Paolo Bonzini <pbonzini@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>, Joerg Roedel <joro@8bytes.org>,
        Borislav Petkov <bp@suse.de>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        David Rientjes <rientjes@google.com>, X86 ML <x86@kernel.org>,
        KVM list <kvm@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>, brijesh.singh@amd.com
Subject: Re: [PATCH 02/12] KVM: SVM: Add KVM_SEND_UPDATE_DATA command
Message-ID: <20200312014910.GC26448@ashkalra_ubuntu_server>
References: <cover.1581555616.git.ashish.kalra@amd.com>
 <b1b4675537fc592a6a78c0ca1888feba0d515557.1581555616.git.ashish.kalra@amd.com>
 <CABayD+cZhCUkEAdCv+qTgvBOzsfDX5Vo8kYATHZDa4PwX_PYiQ@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CABayD+cZhCUkEAdCv+qTgvBOzsfDX5Vo8kYATHZDa4PwX_PYiQ@mail.gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from ashkalra_ubuntu_server (165.204.77.1) by DM5PR11CA0010.namprd11.prod.outlook.com (2603:10b6:3:115::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2793.15 via Frontend Transport; Thu, 12 Mar 2020 01:49:12 +0000
X-Originating-IP: [165.204.77.1]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: c7fd4c6b-ac54-4b85-899d-08d7c62790a8
X-MS-TrafficTypeDiagnostic: DM5PR12MB1691:|DM5PR12MB1691:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM5PR12MB169101951C74060AB52108918EFD0@DM5PR12MB1691.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-Forefront-PRVS: 0340850FCD
X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4636009)(346002)(376002)(396003)(39860400002)(366004)(136003)(199004)(1076003)(9686003)(4744005)(8936002)(66946007)(4326008)(66476007)(54906003)(55016002)(33716001)(8676002)(86362001)(81166006)(33656002)(66556008)(81156014)(5660300002)(16526019)(478600001)(7416002)(316002)(2906002)(186003)(956004)(6916009)(44832011)(6496006)(26005)(52116002);DIR:OUT;SFP:1101;SCL:1;SRVR:DM5PR12MB1691;H:DM5PR12MB1386.namprd12.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;
Received-SPF: None (protection.outlook.com: amd.com does not designate
 permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: m1ad7vQNSFeK+pIRWOXmd3AftGLuLi1y/BOMHyI6vZKtpSY85xeD4/IxWTpfQCmur1oLusu24IM2tWAjz6+h8k3z0RqE31lIrguWqYStEfp7L8CuOzbLUm/uQVgFSEv3MLsItpqCNI/aZpfYihk5GRiGlXtoZz4pc0AGfrPif6kZTQvZDRu0WcUFjN48/6iTmaZMN7+NqJj0aKDE1WqjvcPGhCAHetVm6v8KmB9VYkJz6IKRBV/1G9rqv/6xTsv7P6QpfxGtSYXjxF5TrKj0DmlH9ry1Hfa+XeTR95ZQ4k2sGvHZpYQxosThrt63yon1AGvBJVZF9t6X4J4n9h0lcfD4JUVxTicD0Kw/B0CCdIIGkdsiGwD4QbqG2O5/Xl13gLhv2D5lfMKgBg1JHOVIdvP3kIAUQyxXoG7PBZp/rA33OF6XvM3A2X1yvyDxk3kw
X-MS-Exchange-AntiSpam-MessageData: 9H1Bd3vq/YWU13WIDd2OfPnCa0yU9SbnBROzsDzRqjHUd9y2Y1DexVWhE8Tr2D8M7PPeeQHOUDi1tTFscdXI+c8BPTKcm3CbjTv3NwX0UZx86eQtdbjhQaFJ2vA9IFoUuOwZpIn/z1MxcSsfJsPXAw==
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c7fd4c6b-ac54-4b85-899d-08d7c62790a8
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2020 01:49:13.2791
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: w6BkB7CdP/yA0zUsch7TKZq05lhzF2B+3N1MwQaNJm/Dd5AuQ/oV+ESN/9/LfmHGFjNM5K1Flf3uAKq/2ZM+3A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1691
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Mar 09, 2020 at 06:04:56PM -0700, Steve Rutherford wrote:
> > diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h
> > index 17bef4c245e1..d9dc81bb9c55 100644
> > --- a/include/uapi/linux/kvm.h
> > +++ b/include/uapi/linux/kvm.h
> > @@ -1570,6 +1570,15 @@ struct kvm_sev_send_start {
> >         __u32 session_len;
> >  };
> >
> > +struct kvm_sev_send_update_data {
> > +       __u64 hdr_uaddr;
> > +       __u32 hdr_len;
> > +       __u64 guest_uaddr;
> > +       __u32 guest_len;
> > +       __u64 trans_uaddr;
> > +       __u32 trans_len;
> > +};
> Input from others is welcome here, but I'd put the padding in
> intentionally (explicitly fill in the reserved u8s between *_len and
> *_uaddr). I had to double check that this pattern was intentional and
> matched the SEV spec.

struct kvm_sev_send_update_data{} is used to get/send the information 
from/to userspace, while struct sev_data_send_update_data{} has the
paddings and is packed as required by the SEV spec.

Thanks,
Ashish