Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   afzal mohammed <afzal.mohd.ma@gmail.com>
To:     daniel.lezcano@linaro.org
Cc:     afzal.mohd.ma@gmail.com, allison@lohutok.net, baohua@kernel.org,
        bcm-kernel-feedback-list@broadcom.com, f.fainelli@gmail.com,
        festevam@gmail.com, gregkh@linuxfoundation.org, info@metux.net,
        kernel@pengutronix.de, kgene@kernel.org, khilman@baylibre.com,
        krzk@kernel.org, kstewart@linuxfoundation.org,
        linus.walleij@linaro.org, linux-amlogic@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com,
        linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
        linux@prisktech.co.nz, nsaenzjulienne@suse.de, rjui@broadcom.com,
        s.hauer@pengutronix.de, sbranden@broadcom.com, shawnguo@kernel.org,
        tglx@linutronix.de, u.kleine-koenig@pengutronix.de
Subject: [PATCH v4] clocksource/drivers/timer-cs5535: request irq with non-NULL dev_id
Date:   Thu, 12 Mar 2020 12:18:17 +0530
Message-Id: <20200312064817.19000-1-afzal.mohd.ma@gmail.com>
In-Reply-To: <e47ba222-bf4e-d13c-fbd3-6e7952097188@linaro.org>
References: <e47ba222-bf4e-d13c-fbd3-6e7952097188@linaro.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Recently all usages of setup_irq() was replaced by request_irq().
request_irq() does a few sanity checks that were not done in
setup_irq(), if they fail irq registration will fail. One of the check
is to ensure that non-NULL dev_id is passed in the case of shared irq.

Fix it by passing non-NULL dev_id while registering the shared irq.

Fixes: cc2550b421aa ("clocksource: Replace setup_irq() by request_irq()")
Signed-off-by: afzal mohammed <afzal.mohd.ma@gmail.com>
---

Hi Daniel,

i have assumed that you would not rebase your drivers/next tree & put the
SHA-id in Fixes tag.

Regards
afzal

 drivers/clocksource/timer-cs5535.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/clocksource/timer-cs5535.c b/drivers/clocksource/timer-cs5535.c
index 51ea0509fb25..d47acfe848ae 100644
--- a/drivers/clocksource/timer-cs5535.c
+++ b/drivers/clocksource/timer-cs5535.c
@@ -133,6 +133,7 @@ static irqreturn_t mfgpt_tick(int irq, void *dev_id)
 
 static int __init cs5535_mfgpt_init(void)
 {
+	unsigned long flags = IRQF_NOBALANCING | IRQF_TIMER | IRQF_SHARED;
 	struct cs5535_mfgpt_timer *timer;
 	int ret;
 	uint16_t val;
@@ -152,9 +153,7 @@ static int __init cs5535_mfgpt_init(void)
 	}
 
 	/* And register it with the kernel */
-	ret = request_irq(timer_irq, mfgpt_tick,
-			  IRQF_NOBALANCING | IRQF_TIMER | IRQF_SHARED,
-			  DRV_NAME, NULL);
+	ret = request_irq(timer_irq, mfgpt_tick, flags, DRV_NAME, timer);
 	if (ret) {
 		printk(KERN_ERR DRV_NAME ": Unable to set up the interrupt.\n");
 		goto err_irq;
-- 
2.18.0