Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Peter Chen <peter.chen@nxp.com>
To:     Andrey Konovalov <andreyknvl@google.com>
CC:     Dmitry Vyukov <dvyukov@google.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Alan Stern <stern@rowland.harvard.edu>,
        Andrew Morton <akpm@linux-foundation.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Alexander Potapenko <glider@google.com>,
        Marco Elver <elver@google.com>
Subject: Re: [PATCH v2 3/3] usb: core: kcov: collect coverage from usb
 complete callback
Thread-Topic: [PATCH v2 3/3] usb: core: kcov: collect coverage from usb
 complete callback
Thread-Index: AQHV9kBk+9Olkm/+Q0G93rqDG1Hx5ahEt7UA
Date:   Thu, 12 Mar 2020 09:39:18 +0000
Message-ID: <20200312093920.GD14625@b29397-desktop>
References: <cover.1583778264.git.andreyknvl@google.com>
 <32bce32c8b88c2f88cd0a8acfcdb5d3a6e894632.1583778264.git.andreyknvl@google.com>
In-Reply-To: <32bce32c8b88c2f88cd0a8acfcdb5d3a6e894632.1583778264.git.andreyknvl@google.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-ID: <C0AC0996DECA194E9F7804286B5464E9@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 23bfa394-3280-4c26-b793-08d7c6693c5b
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Mar 2020 09:39:18.2174
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 4X7SH65rutSxQRXDrd16OpFU9p2loxlHV+4Gu4hHvhLMkIC4jS20jJino/sNQmnQmeD6WpCkEFwsA9L81JtNaQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6989
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 20-03-09 19:27:06, Andrey Konovalov wrote:
> This patch adds kcov_remote_start/stop() callbacks around the urb
> complete() callback that is executed in softirq context when dummy_hcd
> is in use. As the result, kcov can be used to collect coverage from those
> those callbacks, which is used to facilitate coverage-guided fuzzing with

Typo, One more "those"

Peter

> syzkaller.
>=20
> Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
> ---
>  drivers/usb/core/hcd.c | 3 +++
>  1 file changed, 3 insertions(+)
>=20
> diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
> index aa45840d8273..de624c47e190 100644
> --- a/drivers/usb/core/hcd.c
> +++ b/drivers/usb/core/hcd.c
> @@ -31,6 +31,7 @@
>  #include <linux/types.h>
>  #include <linux/genalloc.h>
>  #include <linux/io.h>
> +#include <linux/kcov.h>
> =20
>  #include <linux/phy/phy.h>
>  #include <linux/usb.h>
> @@ -1645,7 +1646,9 @@ static void __usb_hcd_giveback_urb(struct urb *urb)
> =20
>  	/* pass ownership to the completion handler */
>  	urb->status =3D status;
> +	kcov_remote_start_usb((u64)urb->dev->bus->busnum);
>  	urb->complete(urb);
> +	kcov_remote_stop();
> =20
>  	usb_anchor_resume_wakeups(anchor);
>  	atomic_dec(&urb->use_count);
> --=20
> 2.25.1.481.gfbce0eb801-goog
>=20

--=20

Thanks,
Peter Chen=