Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
To:     linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org
Cc:     joro@8bytes.org,
        Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Subject: [PATCH] iommu/amd: Fix IOMMU AVIC not properly update the is_run bit in IRTE
Date:   Thu, 12 Mar 2020 05:18:39 -0500
Message-Id: <1584008319-13594-1-git-send-email-suravee.suthikulpanit@amd.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from ssuthiku-rhel7-ssp.amd.com (165.204.78.2) by SN1PR12CA0077.namprd12.prod.outlook.com (2603:10b6:802:20::48) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2793.16 via Frontend Transport; Thu, 12 Mar 2020 10:18:53 +0000
X-Mailer: git-send-email 1.8.3.1
X-Originating-IP: [165.204.78.2]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 5f2f9951-3c51-4782-d67c-08d7c66ec470
X-MS-TrafficTypeDiagnostic: DM6PR12MB2985:|DM6PR12MB2985:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM6PR12MB29850A8ABBA38023F83E1014F3FD0@DM6PR12MB2985.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6430;
X-Forefront-PRVS: 0340850FCD
X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4636009)(396003)(39860400002)(376002)(136003)(366004)(346002)(199004)(2906002)(316002)(16526019)(81166006)(186003)(2616005)(81156014)(8676002)(8936002)(5660300002)(956004)(26005)(36756003)(44832011)(478600001)(7696005)(86362001)(4326008)(66476007)(66556008)(6666004)(6486002)(66946007)(15650500001)(52116002);DIR:OUT;SFP:1101;SCL:1;SRVR:DM6PR12MB2985;H:DM6PR12MB3865.namprd12.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;
Received-SPF: None (protection.outlook.com: amd.com does not designate
 permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 18jrOmPxwG4GMrA4VhXsRA6t0rvekoyNTMd0hghyEbRgogCmeH24yCV2vlfffyN0S7Kt+xyjWZY3rBW/Q2JrMmEYYwumreZ3fAMqP3/5joGJO55fhya5GosNiLj9BI6nhr+D3AIdNngcgpYWWvpj9BW0CgShuPxMLtiHp11/I1Nwn/a7LBny86kAuHCq3nTqTimgJKvZuWxI5MKPGzYnUTprfOmFNOWQRnPwiM/EOYGTEEGTO/1QGTFv6SA6hF/WnER3/rsRYOKl4Q9guPPaj4M8u6bWfQvzm1JCxounCr6pxgtuh4i8Mz67nFMyAeX/wmpj3NI6DsWamyu34p2MnzXuF5EiFknkcemdIH5SkekgPqR2c1sZnvVVQe/B1sZd7Ld1nO7zugBmIQLcSnC1sWnoG2+plsZAqw/icnYDuEITx8lMQn/HEbHHjtAC3LKL
X-MS-Exchange-AntiSpam-MessageData: AxoO+uL6KgJ4U81MdLNOb7YkMmvjkGeMBPV14fAp9VImEd3wAn6Kc9lSMBBOCK+XLsXXq5Ko9sY4b0h/qnxVBD9d7JT5Hx9YTp4mdGvdjYrZcdg94+Uja8inpdwGZ3tOLNvL0b0I1wCdFntdHEpJ8g==
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5f2f9951-3c51-4782-d67c-08d7c66ec470
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2020 10:18:54.3354
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ulmzhlrdfOHj5V3cs4GFh5Va2lIX5BcAjmhPrRS3eJWjnO53Jz/s9Mdow+ZpgxmZXNoKScLwhPvFyGx9nCN5QQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB2985
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Commit b9c6ff94e43a ("iommu/amd: Re-factor guest virtual APIC
(de-)activation code") accidentally left out the ir_data pointer when
calling modity_irte_ga(), which causes the function amd_iommu_update_ga()
to return prematurely due to struct amd_ir_data.ref is NULL and
the "is_run" bit of IRTE does not get updated properly.

This results in bad I/O performance since IOMMU AVIC always generate GA Log
entry and notify IOMMU driver and KVM when it receives interrupt from the
PCI pass-through device instead of directly inject interrupt to the vCPU.

Fixes by passing ir_data when calling modify_irte_ga() as done previously.

Fixes: b9c6ff94e43a ("iommu/amd: Re-factor guest virtual APIC (de-)activation code")
Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
---
 drivers/iommu/amd_iommu.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
index aac132b..20cce36 100644
--- a/drivers/iommu/amd_iommu.c
+++ b/drivers/iommu/amd_iommu.c
@@ -3826,7 +3826,7 @@ int amd_iommu_activate_guest_mode(void *data)
 	entry->lo.fields_vapic.ga_tag      = ir_data->ga_tag;
 
 	return modify_irte_ga(ir_data->irq_2_irte.devid,
-			      ir_data->irq_2_irte.index, entry, NULL);
+			      ir_data->irq_2_irte.index, entry, ir_data);
 }
 EXPORT_SYMBOL(amd_iommu_activate_guest_mode);
 
@@ -3852,7 +3852,7 @@ int amd_iommu_deactivate_guest_mode(void *data)
 				APICID_TO_IRTE_DEST_HI(cfg->dest_apicid);
 
 	return modify_irte_ga(ir_data->irq_2_irte.devid,
-			      ir_data->irq_2_irte.index, entry, NULL);
+			      ir_data->irq_2_irte.index, entry, ir_data);
 }
 EXPORT_SYMBOL(amd_iommu_deactivate_guest_mode);
 
-- 
1.8.3.1