Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 12 Mar 2020 11:47:12 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Peter Chen <peter.chen@nxp.com>
Cc:     lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
        linux-imx@nxp.com
Subject: Re: [PATCH 1/1] regulator: fixed: add system pm routines for pinctrl
Message-ID: <20200312114712.GA4038@sirena.org.uk>
References: <20200312103804.24174-1-peter.chen@nxp.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="Dxnq1zWXvFF0Q93v"
Content-Disposition: inline
In-Reply-To: <20200312103804.24174-1-peter.chen@nxp.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--Dxnq1zWXvFF0Q93v
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Mar 12, 2020 at 06:38:04PM +0800, Peter Chen wrote:
> At some systems, the pinctrl setting will be lost and needs to
> set as "sleep" state to save power consumption after system
> enters suspend. So, we need to configure pinctrl as "sleep" state
> when system enters suspend, and set it as "default" state after
> system resume. In this way, the pinctrl value can be recovered
> as "default" state after resuming.

Which pins exactly is this controlling?  I would not expect a fixed
voltage regulator to have pinctrl support, this feels like it's papering
over some other issue.

--Dxnq1zWXvFF0Q93v
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl5qIToACgkQJNaLcl1U
h9BcLAf9FUIFL9LRfO6s041/3TgyubaeNqbTj9t/WjdTxJHdccmnH20PnQzzBfGs
HC2kn+IBW1FEQ0W+2+n0eM7JUbHx/Ykd004lPmKTltysmS3NA28T8VwHM34uATaI
FP8mN6L1RocPm/o+gWKALo65Bw1tzWvFmTFwBhNM3m1V17PqZyITlJGsm5glqcTl
ujnc9IHLhb+bu64lAknvESsBzjb+PqkgP/wHQZKD3SmqSuiExjK7zG/LhUukNdr8
YqLsopwoKVKsZiricWFz7RLUicGHHTxppPJiTXzQgF8UrlMNiMK5YEqbqEfR6qNy
pqUX/CPX4d8kikr+bLJEqYr4dQeTGQ==
=EglE
-----END PGP SIGNATURE-----

--Dxnq1zWXvFF0Q93v--