Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp470000ybh; Thu, 12 Mar 2020 05:30:06 -0700 (PDT) X-Google-Smtp-Source: ADFU+vv20whR8Kf4M3jk7yh1pzjZRCgEQUHgHEcPqA51Rkm3Ta1gN85+NeUfUdR3/ND+uDLqRCIK X-Received: by 2002:a9d:178:: with SMTP id 111mr6456460otu.238.1584016206674; Thu, 12 Mar 2020 05:30:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584016206; cv=none; d=google.com; s=arc-20160816; b=Ohec/6KRGsdY1vponrDWlKFW2xH4Thg+kjZnrIlKmykLWfoFLGFH5NIEoqwgbdFpoE 7SyOT4K7KGyN8qKkYZnoCLqqZpK2EQyhTI+e8JNxvtxgjjLfLBnfFeWruo/WV1dYLJbl vC/CxWnAUnFRewEoXlC8pWlvzuhWxtP/Ptfw4/m1c/CKQRyIEA1x8fgxpMuEZ9UcM7Vj 3+q70mHjImGWZT2bwDX+JD6Y25eZaQ+g2Z36YM6S1VJDUuXI8mfPHfdCuLnvlmjTddrR 77NnVyQIL89zGKMgP2d/OS7MNFo6wHliGa/I7BA8wRIDZIeFmP8vipvbqATC1JJh7nkN giHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version; bh=zjFcVOAemnoKsr2cIZIjqhkKv+6KDzTh2mCpNYwVHFw=; b=Gp+U8J4ROtGPlRzSjDChduaXl59NmY9JsNiiTMMl/kY5udOYTQWPhJxJT5+uibCot2 lrk227I/KOGQKq8nECOeC79NHJOSa/IFvoXLA5uikfA5tgXoSi77Fay3O6GLDAyR5WRc rEuk7YwIOBDKTr1U07jiIK56OqhcAo1KLbOrKUFvUmAEPupLHaq4UQn2IglbBsFqluMW 15C8PREqt1s44IalqAfYgFMjd5gV9MNV5BjFzZyMStVC2aiS6lw+gpuXiBsKZxflPUd3 b4lkVLlRsofAyeofRRqj3XfVj2BDK0m7XAxbWdVn39V4V4r+3oRtxoWnhU+KdVMcm2zg kkxw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 2si2440975oix.27.2020.03.12.05.29.53; Thu, 12 Mar 2020 05:30:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726558AbgCLM3X (ORCPT + 99 others); Thu, 12 Mar 2020 08:29:23 -0400 Received: from mail-ot1-f65.google.com ([209.85.210.65]:39417 "EHLO mail-ot1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726044AbgCLM3X (ORCPT ); Thu, 12 Mar 2020 08:29:23 -0400 Received: by mail-ot1-f65.google.com with SMTP id a9so5960560otl.6; Thu, 12 Mar 2020 05:29:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zjFcVOAemnoKsr2cIZIjqhkKv+6KDzTh2mCpNYwVHFw=; b=mSKPMazigamgms/JZDxDRl9wOnOf8Kk/jZ3N+hK8E2zgzKinTzLzGJaUz4UdqqYWhp Vpdr2G9qNXK4oiM15kuqP5kXDN8ve7hhg1GvULquditB0spNtP+rD6d6pYp7uhPF6wbj IYPN9dAaPP1ROyyp4u6WxbB3DbHVhcvO9JoeYVRvNUb6vVxaaroimX+G+6quc/0m1ryT 8OUsbA7FjsAeBJ/QYcTgIlve62W62wc0tp3LMfCq+4ASpxWrwqP69vgMYhLdnNr0ZEmm q485NQ16YxbIeIhXHW40vJVQ4397wAb2+i5mhRbyAGtesWkMIdjmmhaMfY0/drHkJct6 VB+A== X-Gm-Message-State: ANhLgQ3rPAd83SXfBLdX6PNX/oUNMqo9YAYWJloG97ynAcNGazz4fRyn dZE7gy8Ht2kkqp6h7RGbcENV7Xbwh4/n2zcxPGdhzCUb X-Received: by 2002:a4a:e211:: with SMTP id b17mr3815296oot.79.1584016162158; Thu, 12 Mar 2020 05:29:22 -0700 (PDT) MIME-Version: 1.0 References: <20200225144749.19815-1-geert+renesas@glider.be> <20200226174905.GE25745@shell.armlinux.org.uk> <20200226175723.GF25745@shell.armlinux.org.uk> In-Reply-To: From: Geert Uytterhoeven Date: Thu, 12 Mar 2020 13:29:11 +0100 Message-ID: Subject: Re: [PATCH] ARM: boot: Fix ATAGs with appended DTB To: Marek Szyprowski Cc: Russell King - ARM Linux admin , Geert Uytterhoeven , Nicolas Pitre , Arnd Bergmann , Eric Miao , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Chris Brandt , Linux ARM , Linux-Renesas , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Marek, On Thu, Mar 12, 2020 at 1:23 PM Marek Szyprowski wrote: > On 26.02.2020 21:48, Geert Uytterhoeven wrote: > > On Wed, Feb 26, 2020 at 6:57 PM Russell King - ARM Linux admin > > wrote: > >> On Wed, Feb 26, 2020 at 06:56:06PM +0100, Geert Uytterhoeven wrote: > >>> On Wed, Feb 26, 2020 at 6:49 PM Russell King - ARM Linux admin > >>> wrote: > >>>> On Wed, Feb 26, 2020 at 07:35:14AM +0100, Marek Szyprowski wrote: > >>>>> On 25.02.2020 15:47, Geert Uytterhoeven wrote: > >>>>>> At early boot, register r8 may contain an ATAGs or DTB pointer. > >>>>>> When an appended DTB is found, its address is stored in r8, for > >>>>>> extraction of the RAM base address later. > >>>>>> > >>>>>> However, if r8 contained an ATAGs pointer before, that pointer will be > >>>>>> lost, and the provided ATAGs is no longer folded into the provided DTB. > >>>>>> > >>>>>> Fix this by leaving r8 untouched. > >>>>>> > >>>>>> Fixes: 137e522593918be2 ("ARM: 8960/1: boot: Obtain start of physical memory from DTB") > >>>>>> Reported-by: Marek Szyprowski > >>>>>> Signed-off-by: Geert Uytterhoeven > >>>> The original commit hasn't been submitted, so it can be fixed before it > >>>> hits mainline if you want. Let me know what you want to do. Thanks. > >>> Fixing the original is fine for me, of course. > >>> Thanks! > >> Please submit a replacement for 8960/1, thanks. > > Done. > > Gentle ping. This fix is still not present in linux-next for over 2 weeks... According to https://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=8963 the fixed version was applied less than one hour ago. It's now part of arm/for-next. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds