Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp553949ybh; Thu, 12 Mar 2020 06:59:29 -0700 (PDT) X-Google-Smtp-Source: ADFU+vvsbOWyphSghf+zrShj5ayBBevsTxE2BbsCPXQ4w4qMGxq5ma1UwY5uJRFlfRtuVnxCpXkm X-Received: by 2002:a05:6830:3090:: with SMTP id f16mr6177650ots.211.1584021568710; Thu, 12 Mar 2020 06:59:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584021568; cv=none; d=google.com; s=arc-20160816; b=f3UBGGGI6wK+QkKSPbpnu/bZHTVZZ/Vmn3uvUXlCvjNooXX1ZmZV8eesIHlpM7cmWl QHBRyYG+OSFEHu4tAU4VAjYTPHTji6rmma6xkPE0g4OCHYvqFCt8fAy6Jyee19aUTtDi x83hv9LBco4sGzok9ZI7FPQVaJE1iBeQxewai/e/1It31LzdvQDPbMmG1pQuuLYkis6m 3G6FHG/QEC6MAvB2AUNnKzRmjStzbZfCU04FiWF2ARQ/j1xitMJLa3XzFwoBhJVjApPj HPV48GvcTiHEKdVCE/LBbdLHt7WNxU4GI24TftJ3sX+8+0Ll13cvKmc/wKCQTQJnmUBf B28Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=PmCzpDN/NMRhyTEmPMiyBIQCmmnvomJEacJijlrbzM4=; b=yNmYAySzsDsKpA/6+ijj6MXHP6N9HbR+nJFC5dpGRMqYdE2Nuw23oyx72qLb7fOyOL 3d9JASRnxyVs6+hCA+6eW3QGX4+bkB7qHdPG8lk5YELavnmfDXxDB3V1oVctWJnPi0t5 EYDYt4U6+x4YVFe9ThKdzb2lmgmyG909PL32tK5v4pVWzeR2FREKF0pnDEP0RYKC+Vot z7KvNc9zkYCYCAY6n5vHlGKCznt0vRHNa9UyxJamFYS9G3O9lMm4boRrwV2HiCpXrtVB T5Zz118YkPc1Tm/fjuk2Oys/eaXGbEITwUIXiQtsWT72wNEHDoUZZBVZUm/Kr/T0GI6n tWNA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=AVrW7+rS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d23si2761132oig.118.2020.03.12.06.59.15; Thu, 12 Mar 2020 06:59:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=AVrW7+rS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727409AbgCLN5b (ORCPT + 99 others); Thu, 12 Mar 2020 09:57:31 -0400 Received: from mail-io1-f67.google.com ([209.85.166.67]:37135 "EHLO mail-io1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727007AbgCLN5b (ORCPT ); Thu, 12 Mar 2020 09:57:31 -0400 Received: by mail-io1-f67.google.com with SMTP id k4so5767797ior.4 for ; Thu, 12 Mar 2020 06:57:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=PmCzpDN/NMRhyTEmPMiyBIQCmmnvomJEacJijlrbzM4=; b=AVrW7+rSwrTmOjEOzng0oQCcIDCWV2si013XLwgHe6kixGzc7dstefqkGGSrsRVsAa FJE5c8jj9IlF0m0dMAhvHAI8L2U5z6bsisEYr8MliPCpIKguC+xfFP8F0WTnFm4+b0bq Fifux4zNzTJyMwxaYofa0zz8c/fczmTMV72sT6ZMw2K/qkUWZFqYOeB4JqKYqXOoDy7G m/lS4YnuTImXVHmsWTGe4vzNuDCRyyv0A6mKgrn7VmUN3Ao6sR9KYbWhRQSAUju2PiMf TRnCHWJ9L0Q9+VL2EyBZ5TsRl92cRG+4ULNLFYL+96dQGAluT2xt8/JIWGS0S5p/BZ2g j/dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=PmCzpDN/NMRhyTEmPMiyBIQCmmnvomJEacJijlrbzM4=; b=UlPbY9/AtpMEaHhKUW2KSpxDAI/UcKoPEj7gbHvhNGfB/vu43wmE9TSb/icuEpobzs uLhOCmp5NZR5XZkrJxA1sb69vifdkdYrlBImAxJSF0Bw2tprbCmCRmHdZQKK9Bjpp0oQ sIFCy07FefsfGnnUCgRGdU79dpl+2+Cy6LlToIkzIs1I3s+7ZKZt3KD/1OR8xcMEstC3 M0XZz0OFibucgV7d5fR8GPtCLgsygLGMTQkMH7UNXC0PMFPPvqeYlVZH+rWMRQZr13V/ JgboSWxKt03Mebj+zU0K20Pb7P6AbbjaBsLuvYhL9lcRIopF1X+Pn2fcJA8SYRMFTvC0 mM8w== X-Gm-Message-State: ANhLgQ0ObjGbADOnEXW54gideRmIRrvMmcEQjvT+uVodcrpL80y1aBxk 5w9+6m2WK4lD0oOkaeR2i7XoSygJjJjZQg== X-Received: by 2002:a5d:9708:: with SMTP id h8mr7755881iol.141.1584021448333; Thu, 12 Mar 2020 06:57:28 -0700 (PDT) Received: from [192.168.1.159] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id r29sm8822455ilk.76.2020.03.12.06.57.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Mar 2020 06:57:27 -0700 (PDT) Subject: Re: [PATCH 1/1] null_blk: describe the usage of fault injection param To: Dongli Zhang , linux-block@vger.kernel.org Cc: linux-kernel@vger.kernel.org References: <20200304191644.25220-1-dongli.zhang@oracle.com> From: Jens Axboe Message-ID: <052ba0ac-e0ec-9607-e5c8-acbee8ab6162@kernel.dk> Date: Thu, 12 Mar 2020 07:57:26 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200304191644.25220-1-dongli.zhang@oracle.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/4/20 12:16 PM, Dongli Zhang wrote: > As null_blk is a very good start point to test block layer, this patch adds > description and comments to 'timeout' and 'requeue' to explain how to use > fault injection with null_blk. > > The nvme has similar with nvme_core.fail_request in the form of comment. This doesn't apply to for-5.7/drivers, care to resend? -- Jens Axboe