Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v3 00/27] ata: optimize core code size on PATA only setups
To:     Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc:     Michael Schmitz <schmitzmic@gmail.com>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Christoph Hellwig <hch@lst.de>, linux-ide@vger.kernel.org,
        linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org
References: <CGME20200227182238eucas1p1a4a5546e46b2385057f41528bd759aea@eucas1p1.samsung.com>
 <20200227182226.19188-1-b.zolnierkie@samsung.com>
From:   Jens Axboe <axboe@kernel.dk>
Message-ID: <15a1618d-a2fe-8911-764f-0d7204895ddb@kernel.dk>
Date:   Thu, 12 Mar 2020 08:09:22 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <20200227182226.19188-1-b.zolnierkie@samsung.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2/27/20 11:21 AM, Bartlomiej Zolnierkiewicz wrote:
> Hi,
> 
> There have been reports in the past of libata core code size
> being a problem in migration from deprecated IDE subsystem on
> legacy PATA only systems, i.e.:
> 
> https://lore.kernel.org/linux-ide/db2838b7-4862-785b-3a1d-3bf09811340a@gmail.com/
> 
> This patchset re-organizes libata core code to exclude SATA
> specific code from being built for PATA only setups.
> 
> The end result is up to 24% (by 23949 bytes, from 101769 bytes to
> 77820 bytes) smaller libata core code size (as measured for m68k
> arch using modified atari_defconfig) on affected setups.
> 
> I've tested this patchset using pata_falcon driver under ARAnyM
> emulator.
> 
> 
> patches #1-11 are general fixes/cleanups done in the process of
> making the patchset (there should be no inter-dependencies between
> them except patch #10 which depends on patch #9)
> 
> patch #12 separates PATA timings code to libata-pata-timings.c file
> 
> patches #13-15 let compiler optimize out SATA specific code on
> non-SATA hosts by adding !IS_ENABLED(CONFIG_SATA_HOST) instances
> 
> patches #16-22 separate SATA only code from libata-core.c file to
> libata-sata.c one
> 
> patches #23-24 separate SATA only code from libata-scsi.c file to
> libata-sata.c one
> 
> patches #25-26 separate SATA only code from libata-eh.c file to
> libata-sata.c one
> 
> patch #27 makes "libata.force" kernel parameter optional

Bart, patch #2 seemed to have an issue, are you going to resend
this patchset?

-- 
Jens Axboe