Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp593553ybh; Thu, 12 Mar 2020 07:37:26 -0700 (PDT) X-Google-Smtp-Source: ADFU+vv6+R8mVrjEMJliC6xH+ir5WIXik6p4V/4/cME7m9UzQWG/GSvvuVDwqGmLcXAk6tJaSj3o X-Received: by 2002:aca:4e08:: with SMTP id c8mr2861809oib.143.1584023846509; Thu, 12 Mar 2020 07:37:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584023846; cv=none; d=google.com; s=arc-20160816; b=dY8PdQLb/UCoU6WW2xblkOGQQMvYiLOHoTcsvMjwnXPaJZe1tyFwSSv9HzmYQ7Hp1f AyGpMwXreoJFcSW41LSMfOv5LNNAeq65s1PyYTHyZlsYMc46WPPmHQAeXqjtaX/T91pw cFfR5yjb983D9bsgLC/1W32hAT/dIq6wTl4sk/QVXmBoGv6RrTUXSkO5nnbehl8/B/5D 62Us8/jPZYyRS9W8rYGhqfLiRQhpqsjgjcy9fXyOxBbnGx4R9BLgJpiu/iGwBPA2Dhks VWtnL0mTdkjZOSTFt2eYiO5qwFIPIPblKLjGXpd86QsMx9XW8c0iWGASpyN/UlO5E2RE 2k/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject:dkim-signature; bh=Q4FiQLXhjwStZmOYzHQGfmnzPhLI0zvMi+wXTYLHpTk=; b=PdarAiZ9jFuDQSrJmUxKRSea5nLOrPk5zEuO5VTdzXpXuzP9rKASLSFCgOOJ5qHT8C ahLDuU1seSxbQTxM4cVqMgBX6jDTAuLU3PlsuJikNb1UkmozvIOk9igQeLhgc6hn4yDN jchk0d7WNRqiegg3G7FoS6olfj+Y3H4JxUy3c48xgSUsNtQI2q3rdykl0QZY2aKcp+a6 h0REtBHma+i++3JOKN0huAxPeuSPBvz3WnMSgeatRW2hNbVcRNTDyDJgNsTBFWDSdR4O jYT630ltr+k4AP0y3mlfIQW3SF6WpRZqmllg1fs27DLRi4GDYrOQBczZkvDZ3fWG03v2 GeWg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=Cm60S2dW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u136si1105534oif.197.2020.03.12.07.37.13; Thu, 12 Mar 2020 07:37:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=Cm60S2dW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727505AbgCLOfd (ORCPT + 99 others); Thu, 12 Mar 2020 10:35:33 -0400 Received: from mail-io1-f65.google.com ([209.85.166.65]:40764 "EHLO mail-io1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727430AbgCLOfd (ORCPT ); Thu, 12 Mar 2020 10:35:33 -0400 Received: by mail-io1-f65.google.com with SMTP id d8so5878137ion.7 for ; Thu, 12 Mar 2020 07:35:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=Q4FiQLXhjwStZmOYzHQGfmnzPhLI0zvMi+wXTYLHpTk=; b=Cm60S2dWe8JeJkat+EMyGodxi2i2wiUkKIZy7EHVeo9mTS15Tpb57ERxbwzulv7UDu Ft2N6+TI5UPC344muYxQk4MCjyfeRLvhY7oSpL0I6dgCiHG5zRM8bVVBUXbRzr6a7XpL uXzPEzJLYoiwFQETYmhPHWPWdAJbrwsKlc50PlIjqWHbQObsC8M4HZaIisDGUkgvWqHi 0eQKYdl7KiTGNbUXzcvSDzm8lCwDxFsDzgaSbKVxxvbmY05thnX9YAHQ7iuHq+kb7z5e uRDW67gmW9J18Y8PsE6Gc942nGaRbX7XiS6x5T3er7G3cQ3DbWGQ0el3pOSC0JEUNKAJ KGCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Q4FiQLXhjwStZmOYzHQGfmnzPhLI0zvMi+wXTYLHpTk=; b=NUdvGXH0y7xnQHSCTR3hq5E5ph9guPDv1N7iSPOK2NcLP3LMhXsNc+oxWhlVM+kvfT GBr1vYymfIPyGQ5L2/nO8dyz2FxOSHW/OYMjaXJibbzR0dodxh7dZD2gmQHv6gu5AVNQ cQRIv5w+LgngsWCPyARbOIgGjpKsLhum8LJx3YMhRMT/IEWyWs3rMywixC0wlqXk/IEk 2ByHd4f6a6HXRzcMiUW7ZR6oX3inSbIOghbgjI4A8rq1eigUORX2uJDobAO/5QsNLSjS duzuSZE45nL602W6e6t66kvgNU8Udk7l7ef0mczRsFXu7BChvhJig9KFvRP281l56Al6 9yFw== X-Gm-Message-State: ANhLgQ3lZHS1kyUH/Ld2RHzLjWh1NLOJzieBTNan5avqj2gxedizWIZv 1Q88gETNAuTcO2/cvOYErzZv0HRJgw/vfQ== X-Received: by 2002:a6b:7407:: with SMTP id s7mr7988540iog.11.1584023730700; Thu, 12 Mar 2020 07:35:30 -0700 (PDT) Received: from [192.168.1.159] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id x7sm8719674ill.19.2020.03.12.07.35.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Mar 2020 07:35:30 -0700 (PDT) Subject: Re: [PATCH 1/1] io-wq: remove duplicated cancel code To: Pavel Begunkov , io-uring@vger.kernel.org, linux-kernel@vger.kernel.org References: <883f200570ee22c8081469bd571bec5fb27da4c5.1583531319.git.asml.silence@gmail.com> From: Jens Axboe Message-ID: <277bb693-d5ad-b021-7ea9-d935f878215f@kernel.dk> Date: Thu, 12 Mar 2020 08:35:29 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <883f200570ee22c8081469bd571bec5fb27da4c5.1583531319.git.asml.silence@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/6/20 3:15 PM, Pavel Begunkov wrote: > Deduplicate cancellation parts, as many of them looks the same, as do > e.g. > - io_wqe_cancel_cb_work() and io_wqe_cancel_work() > - io_wq_worker_cancel() and io_work_cancel() Looks good to me, and passes my initial testing. Applied! -- Jens Axboe