Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp626006ybh; Thu, 12 Mar 2020 08:11:22 -0700 (PDT) X-Google-Smtp-Source: ADFU+vtK6/p723Ki21f7tGMQrgavlXIDYFZEfrOcentXa1MONh5BoG/187GxRdCTv/IYvwMLqqx3 X-Received: by 2002:aca:1c0d:: with SMTP id c13mr2871724oic.94.1584025882037; Thu, 12 Mar 2020 08:11:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584025882; cv=none; d=google.com; s=arc-20160816; b=Z4s/1lQwQ9D8LFB86+ME74PGyLRUS/aVUAT3YUTovK87fE/JKko8d/hLof3pMfvYXb CNP9e9ubrsUS7Jq2A9b0c3nQJHUDXx8+vpQIi9jTHtiaQwB0he1p915KQG4lqtvI6Llt zGQuv8ZTgUEuYQ9sL3HYdjiFNE6vfC1TIoTW4UiyKXMeh2O27gHDb6MRijT+AiU790PJ uN2wIAMOUYXSGyezxa3wi+EVzkBcNFVosgOrX7tqPI43EadW7qQ72jMlKvAmsJh4YvWh RtgC7BzAh15NLBJf8u6NqYfNkEDVYL23BTa3yqxiXfRppJpGe69eDjgM1cI4NfPtMg/C C5lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=uPjFqZx/6I5Qs44mY7asg2IZtVGs/xJSbZwp2GMuxw0=; b=rTwyXzh9W8+RodpO13KKtXDgdVnCVwj5Rma8WTn6aLR6VLh0tlgHBx0SS1JndtisNc 5gJYNxAMJ4NhrtyeOJN1lqgsXqvXZxDu7dOP/k05nUrAKdGScE3gXuaRosu+DWEuyAPs O7iDJ1kd7HXGge3ERR/AxkAEv3Qulcf7IZTrNT+w+KayXXMYhmfYcmE84U+KKAUbMLFV DwMPrfWL3O1KSRG+FnE3MhHvhX2q+/jr2VBZFs90CcJ40pkJYRS4vtipIOOV2/Yod0+a 1kIK6eSh2d0Rl2ob9rtk9t+5U081naTNY1I/fK4Otw91vyJlwiaRHhkeWSG4j0EKkm+s HQsA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h7si3034728otk.84.2020.03.12.08.11.07; Thu, 12 Mar 2020 08:11:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727766AbgCLPHN (ORCPT + 99 others); Thu, 12 Mar 2020 11:07:13 -0400 Received: from foss.arm.com ([217.140.110.172]:36456 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727133AbgCLPHN (ORCPT ); Thu, 12 Mar 2020 11:07:13 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D273B30E; Thu, 12 Mar 2020 08:07:12 -0700 (PDT) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5667F3F534; Thu, 12 Mar 2020 08:07:12 -0700 (PDT) Date: Thu, 12 Mar 2020 15:07:10 +0000 From: Mark Brown To: Peter Chen Cc: "lgirdwood@gmail.com" , "linux-kernel@vger.kernel.org" , dl-linux-imx Subject: Re: [PATCH 1/1] regulator: fixed: add system pm routines for pinctrl Message-ID: <20200312150710.GG4038@sirena.org.uk> References: <20200312103804.24174-1-peter.chen@nxp.com> <20200312114712.GA4038@sirena.org.uk> <20200312130037.GG14625@b29397-desktop> <20200312143723.GF4038@sirena.org.uk> <20200312150330.GH14625@b29397-desktop> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="iAL9S67WQOXgEPD9" Content-Disposition: inline In-Reply-To: <20200312150330.GH14625@b29397-desktop> X-Cookie: Security check: =?ISO-8859-1?Q?=20=07=07=07INTRUDER?= ALERT! User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --iAL9S67WQOXgEPD9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Mar 12, 2020 at 03:03:26PM +0000, Peter Chen wrote: > On 20-03-12 14:37:23, Mark Brown wrote: > > Surely it's the GPIO controller that needs pinctrl support then? > But the pinctrl register value for this gpio will be cleared after > suspend, we need to restore it, otherwise, the function will be not > gpio. See below patch: I'd expect that this would be handled by the GPIO driver, the user shouldn't need to care. --iAL9S67WQOXgEPD9 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl5qUB4ACgkQJNaLcl1U h9A2lwf+KwAx2wKqIxrmgCUh4bwdLI99EGL396CbJ3ww5s7DbJ3LQ8xCoIWyeUj1 3QDZPb1D+ssHLm8NHd38ENdymLKODxBec7oCgPCb+V95fCY9K9VEVuMEutldZK3C UUn5NjE7VU7lI0ccfW1xWR/36bPOJVVizpNymH3HqffLnJT0yU0OQJnmyoGEi2Xo QQg0s4ewdf6Tq6VddR457VMUk2B9uCmKBtOeMB2RarLj+KlamJQHwht7W4R1d1qI NQTntqip/UGSt/SSHci3T+XgNG6Ic1ko+/mHnyrQcKohA4UzsaSz8BK/batfhEqL HxELrI/BPZLg15ZQ7rSO31bh1Nedwg== =4ZCB -----END PGP SIGNATURE----- --iAL9S67WQOXgEPD9--