Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v7 22/48] Input: atmel_mxt_ts - improve bootloader state
 machine handling
To:     Jiada Wang <jiada_wang@mentor.com>, jikos@kernel.org,
        benjamin.tissoires@redhat.com, rydberg@bitmath.org,
        dmitry.torokhov@gmail.com, nick@shmanahar.org, bsz@semihalf.com
Cc:     linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
        erosca@de.adit-jv.com, Andrew_Gabbasov@mentor.com
References: <20200212084218.32344-1-jiada_wang@mentor.com>
 <20200212084218.32344-23-jiada_wang@mentor.com>
From:   Dmitry Osipenko <digetx@gmail.com>
Message-ID: <bba38969-b245-6b79-3836-099c2ded3c22@gmail.com>
Date:   Thu, 12 Mar 2020 18:28:25 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.5.0
MIME-Version: 1.0
In-Reply-To: <20200212084218.32344-23-jiada_wang@mentor.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

12.02.2020 11:41, Jiada Wang пишет:
> From: Nick Dyer <nick.dyer@itdev.co.uk>
> 
> The code is much clearer if we switch on the actual state the bootloader
> is in, rather than the state we want it to be in, and allows the removal
> of a goto retry tangle.

...
>  	case MXT_WAITING_FRAME_DATA:
> -	case MXT_APP_CRC_FAIL:
> -		val &= ~MXT_BOOT_STATUS_MASK;
> +		if ((f->previous != MXT_WAITING_BOOTLOAD_CMD)
> +		    && (f->previous != MXT_FRAME_CRC_PASS)
> +		    && (f->previous != MXT_FRAME_CRC_FAIL))

This will cleaner to write as follows:

		if (f->previous != MXT_WAITING_BOOTLOAD_CMD &&
		    f->previous != MXT_FRAME_CRC_PASS &&
		    f->previous != MXT_FRAME_CRC_FAIL)