Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Thu, 12 Mar 2020 17:50:40 +0100
From:   Michael Walle <michael@walle.cc>
To:     linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Cc:     "David S . Miller" <davem@davemloft.net>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Vladimir Oltean <vladimir.oltean@nxp.com>,
        Rob Herring <robh+dt@kernel.org>, Li Yang <leoyang.li@nxp.com>,
        Shawn Guo <shawnguo@kernel.org>
Subject: Re: [PATCH 2/2] arm64: dts: ls1028a: disable the felix switch by
 default
In-Reply-To: <20200312164320.22349-2-michael@walle.cc>
References: <20200312164320.22349-1-michael@walle.cc>
 <20200312164320.22349-2-michael@walle.cc>
Message-ID: <5c06000e9ca893cdf431f29618428630@walle.cc>
User-Agent: Roundcube Webmail/1.3.10
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Am 2020-03-12 17:43, schrieb Michael Walle:
> Disable the felix switch by default and enable it per board which are
> actually using it.
> 
> Signed-off-by: Michael Walle <michael@walle.cc>

I forgot to mention that this patch depends on the following series:
   
https://lore.kernel.org/linux-devicetree/20200311074929.19569-1-michael@walle.cc/

Sorry,
-michael

> ---
>  .../boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dts  | 4 ++++
>  .../boot/dts/freescale/fsl-ls1028a-kontron-sl28-var2.dts      | 4 ++++
>  arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts             | 4 ++++
>  arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi                | 3 ++-
>  4 files changed, 14 insertions(+), 1 deletion(-)
> 
> diff --git
> a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dts
> b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dts
> index a83a176cf18a..d4ca12b140b4 100644
> --- 
> a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dts
> +++ 
> b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dts
> @@ -63,6 +63,10 @@
>  	};
>  };
> 
> +&mscc_felix {
> +	status = "okay";
> +};
> +
>  &mscc_felix_port0 {
>  	label = "swp0";
>  	managed = "in-band-status";
> diff --git
> a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var2.dts
> b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var2.dts
> index 0a34ff682027..901b5b161def 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var2.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var2.dts
> @@ -48,6 +48,10 @@
>  	status = "okay";
>  };
> 
> +&mscc_felix {
> +	status = "okay";
> +};
> +
>  &mscc_felix_port0 {
>  	label = "gbe0";
>  	phy-handle = <&phy0>;
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> index 0d27b5667b8c..8294d364112e 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> @@ -228,6 +228,10 @@
>  	status = "okay";
>  };
> 
> +&mscc_felix {
> +	status = "okay";
> +};
> +
>  &mscc_felix_port0 {
>  	label = "swp0";
>  	managed = "in-band-status";
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> index c09279379723..70a10268bb83 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> @@ -933,10 +933,11 @@
>  				fsl,extts-fifo;
>  			};
> 
> -			ethernet-switch@0,5 {
> +			mscc_felix: ethernet-switch@0,5 {
>  				reg = <0x000500 0 0 0 0>;
>  				/* IEP INT_B */
>  				interrupts = <GIC_SPI 95 IRQ_TYPE_LEVEL_HIGH>;
> +				status = "disabled";
> 
>  				ports {
>  					#address-cells = <1>;