Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp803230ybh; Thu, 12 Mar 2020 11:24:38 -0700 (PDT) X-Google-Smtp-Source: ADFU+vslfSOXuhJWvopSsXEAPYo6/1ZT7LFrEWzOD/grAWRtijA4twZr9IOrDZXLl5kz6VkLJQrI X-Received: by 2002:aca:1b09:: with SMTP id b9mr3703313oib.170.1584037478787; Thu, 12 Mar 2020 11:24:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584037478; cv=none; d=google.com; s=arc-20160816; b=eOi6EEThFYv7bbmDbYVPrpvkpB7SbJpkQL9zBOrNTpe+RyuWNyzKdTnYosy1xwpcso zNrjFo3R6j2ywH7UOjSp7/5bMi9XFDghQAy1umQBEZGk519D9CPEzBzrlkKM0qR3WNev qLWp3GMWvQOJLw0Nqac61B+iPnJeOJDCvVMxQlJVYdeL5raGCO4UbKpPgkn1BiP0gqDB EFRhIvotNfCVLbLqWbfgSReMkzIgFv3OT0xduRoUhCxvxx0S2ndkvN/aBmGxBjVHnB9j 91bCM7oFefwpKdBxJ7OK2F1S6dBS01iDNOtFayKnSYAsFughkyJOuAY6Ag7rpRDGuQn/ 7Bbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject:dkim-signature; bh=I14sMSo/8MVABSeQ92m+2OlhrLjEldKHbCJhA070FMM=; b=fYFeCipGIOj1f+jqM5zwKC/7WhG9pTMmrTnxw7q5/xUaFlVp+CF9psRYRoN1WbMUko sMhW2NME8hZg4fPWmRag6Rls3HzReMmyjocqf7CanywaA8OKbbESpTtLHRahrMEZCa+7 zsec5Xt86KBq+P1y2eDFAMmgMOAoXt8RV8+lD7nlyhYmpA1Y96CSxA0TI7PS7vPSNZiL 8pX3bq1mxxfZtv4Zq8mEHIF9ot4XNuE1WMFTzJ45gHqHzhy0xY62MlWJU3smCoPHZ3ER AGM6CulbA8GYWsGu+bN/enwIYgvqaAcU6fydquaJh4747dKK5w2BZTkVmhP7Q728zlQ6 xSlw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=w0g4KW02; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l143si1654908oih.269.2020.03.12.11.24.26; Thu, 12 Mar 2020 11:24:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=w0g4KW02; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726692AbgCLSXr (ORCPT + 99 others); Thu, 12 Mar 2020 14:23:47 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:38830 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726680AbgCLSXq (ORCPT ); Thu, 12 Mar 2020 14:23:46 -0400 Received: by mail-wm1-f68.google.com with SMTP id t13so1102801wmi.3 for ; Thu, 12 Mar 2020 11:23:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=I14sMSo/8MVABSeQ92m+2OlhrLjEldKHbCJhA070FMM=; b=w0g4KW0228iK6+VDBJuLrvfGiYRjECwQ/QqYZjJtsZw49UoCTxVQPtDn4OHUpzfKg1 voeA2jH5ucovbtQWB+7FlVurob7LeCLqLsM6XBaxwWs6Cie+9zydk1jTEcn5hvb0oBJe benilUYQCNJwlIOA4E4dfilPB/3WJzRN+reyechxBdXydB9FXgootOixx+M8oNKj0Qo8 StRKVl0gD42VSEYYJbEP5bcCOflrslJZFk/phkBrP9NZiccShNAccCKjNEVFBqDF8Dwz jwgzEADqv6u0pqbSIxRx5dWHyddhcOiq7WDhTVqH9gYAMEnYK0kXSXtVWUlZN/Eydp0I Eyqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=I14sMSo/8MVABSeQ92m+2OlhrLjEldKHbCJhA070FMM=; b=ZubHV57sh6/rt6HAr4IrPl1FAyjgwaaWPz1jUqOiA9o4Fy5hHvfjwTKhSl5+UvPGLF ft1mnf/HEtgEddmZMmx/QrC7PlovXKM+sy3nqrOQ+stDMytbhPDklxrlEtA8yMSunHHD DXkd/4GjSUXRZKxCnuTSYGZNuJwRBXP3bal3z3zZ7BSumczZki2b7C5JpOfe66fhbXDr lxXBd/pP9FPRg6X57y5spcKWVQjWkyae1MjtIa7Z0nkPzJBGzxF3ZDTw4bGnWq5+cjCL PHE80t39cPeZHibVuOEnslsMdDH5zcwppof/cHTTyIVThwQ+fCfKXz8R/k6viXOvd9yi bHaw== X-Gm-Message-State: ANhLgQ1kJXtNnTAPxY00RxX8ext7HTQmdlEimFQHgto17UI1U8osUFRb azTN9NqF1zWuMBJbjYaOoVP91w== X-Received: by 2002:a1c:44b:: with SMTP id 72mr6182095wme.116.1584037424748; Thu, 12 Mar 2020 11:23:44 -0700 (PDT) Received: from ?IPv6:2a01:e34:ed2f:f020:40fb:3990:3519:cc26? ([2a01:e34:ed2f:f020:40fb:3990:3519:cc26]) by smtp.googlemail.com with ESMTPSA id e7sm56423305wrt.70.2020.03.12.11.23.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Mar 2020 11:23:44 -0700 (PDT) Subject: Re: [PATCH v4] clocksource/drivers/timer-cs5535: request irq with non-NULL dev_id To: afzal mohammed Cc: allison@lohutok.net, baohua@kernel.org, bcm-kernel-feedback-list@broadcom.com, f.fainelli@gmail.com, festevam@gmail.com, gregkh@linuxfoundation.org, info@metux.net, kernel@pengutronix.de, kgene@kernel.org, khilman@baylibre.com, krzk@kernel.org, kstewart@linuxfoundation.org, linus.walleij@linaro.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux@prisktech.co.nz, nsaenzjulienne@suse.de, rjui@broadcom.com, s.hauer@pengutronix.de, sbranden@broadcom.com, shawnguo@kernel.org, tglx@linutronix.de, u.kleine-koenig@pengutronix.de References: <20200312064817.19000-1-afzal.mohd.ma@gmail.com> From: Daniel Lezcano Autocrypt: addr=daniel.lezcano@linaro.org; prefer-encrypt=mutual; keydata= xsFNBFv/yykBEADDdW8RZu7iZILSf3zxq5y8YdaeyZjI/MaqgnvG/c3WjFaunoTMspeusiFE sXvtg3ehTOoyD0oFjKkHaia1Zpa1m/gnNdT/WvTveLfGA1gH+yGes2Sr53Ht8hWYZFYMZc8V 2pbSKh8wepq4g8r5YI1XUy9YbcTdj5mVrTklyGWA49NOeJz2QbfytMT3DJmk40LqwK6CCSU0 9Ed8n0a+vevmQoRZJEd3Y1qXn2XHys0F6OHCC+VLENqNNZXdZE9E+b3FFW0lk49oLTzLRNIq 0wHeR1H54RffhLQAor2+4kSSu8mW5qB0n5Eb/zXJZZ/bRiXmT8kNg85UdYhvf03ZAsp3qxcr xMfMsC7m3+ADOtW90rNNLZnRvjhsYNrGIKH8Ub0UKXFXibHbafSuq7RqyRQzt01Ud8CAtq+w P9EftUysLtovGpLSpGDO5zQ++4ZGVygdYFr318aGDqCljKAKZ9hYgRimPBToDedho1S1uE6F 6YiBFnI3ry9+/KUnEP6L8Sfezwy7fp2JUNkUr41QF76nz43tl7oersrLxHzj2dYfWUAZWXva wW4IKF5sOPFMMgxoOJovSWqwh1b7hqI+nDlD3mmVMd20VyE9W7AgTIsvDxWUnMPvww5iExlY eIC0Wj9K4UqSYBOHcUPrVOKTcsBVPQA6SAMJlt82/v5l4J0pSQARAQABzSpEYW5pZWwgTGV6 Y2FubyA8ZGFuaWVsLmxlemNhbm9AbGluYXJvLm9yZz7Cwa4EEwEIAEECGwEFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4ACGQEWIQQk1ibyU76eh+bOW/SP9LjScWdVJwUCXAkeagUJDRnjhwAh CRCP9LjScWdVJxYhBCTWJvJTvp6H5s5b9I/0uNJxZ1Un69gQAJK0ODuKzYl0TvHPU8W7uOeu U7OghN/DTkG6uAkyqW+iIVi320R5QyXN1Tb6vRx6+yZ6mpJRW5S9fO03wcD8Sna9xyZacJfO UTnpfUArs9FF1pB3VIr95WwlVoptBOuKLTCNuzoBTW6jQt0sg0uPDAi2dDzf+21t/UuF7I3z KSeVyHuOfofonYD85FkQJN8lsbh5xWvsASbgD8bmfI87gEbt0wq2ND5yuX+lJK7FX4lMO6gR ZQ75g4KWDprOO/w6ebRxDjrH0lG1qHBiZd0hcPo2wkeYwb1sqZUjQjujlDhcvnZfpDGR4yLz 5WG+pdciQhl6LNl7lctNhS8Uct17HNdfN7QvAumYw5sUuJ+POIlCws/aVbA5+DpmIfzPx5Ak UHxthNIyqZ9O6UHrVg7SaF3rvqrXtjtnu7eZ3cIsfuuHrXBTWDsVwub2nm1ddZZoC530BraS d7Y7eyKs7T4mGwpsi3Pd33Je5aC/rDeF44gXRv3UnKtjq2PPjaG/KPG0fLBGvhx0ARBrZLsd 5CTDjwFA4bo+pD13cVhTfim3dYUnX1UDmqoCISOpzg3S4+QLv1bfbIsZ3KDQQR7y/RSGzcLE z164aDfuSvl+6Myb5qQy1HUQ0hOj5Qh+CzF3CMEPmU1v9Qah1ThC8+KkH/HHjPPulLn7aMaK Z8t6h7uaAYnGzjMEXZLIEhYJKwYBBAHaRw8BAQdAGdRDglTydmxI03SYiVg95SoLOKT5zZW1 7Kpt/5zcvt3CwhsEGAEIACAWIQQk1ibyU76eh+bOW/SP9LjScWdVJwUCXZLIEgIbAgCvCRCP 9LjScWdVJ40gBBkWCAAdFiEEbinX+DPdhovb6oob3uarTi9/eqYFAl2SyBIAIQkQ3uarTi9/ eqYWIQRuKdf4M92Gi9vqihve5qtOL396pnZGAP0c3VRaj3RBEOUGKxHzcu17ZUnIoJLjpHdk NfBnWU9+UgD/bwTxE56Wd8kQZ2e2UTy4BM8907FsJgAQLL4tD2YZggwWIQQk1ibyU76eh+bO W/SP9LjScWdVJ5CaD/0YQyfUzjpR1GnCSkbaLYTEUsyaHuWPI/uSpKTtcbttpYv+QmYsIwD9 8CeH3zwY0Xl/1fE9Hy59z6Vxv9YVapLx0nPDOA1zDVNq2MnutxHb8t+Imjz4ERCxysqtfYrv gao3E/h0c8SEeh+bh5MkjwmU8CwZ3doWyiVdULKESe7/Gs5OuhFzaDVPCpWdsKdCAGyUuP/+ qRWwKGVpWP0Rrt6MTK24Ibeu3xEZO8c3XOEXH5d9nf6YRqBEIizAecoCr00E9c+6BlRS0AqR OQC3/Mm7rWtco3+WOridqVXkko9AcZ8AiM5nu0F8AqYGKg0y7vkL2LOP8us85L0p57MqIR1u gDnITlTY0x4RYRWJ9+k7led5WsnWlyv84KNzbDqQExTm8itzeZYW9RvbTS63r/+FlcTa9Cz1 5fW3Qm0BsyECvpAD3IPLvX9jDIR0IkF/BQI4T98LQAkYX1M/UWkMpMYsL8tLObiNOWUl4ahb PYi5Yd8zVNYuidXHcwPAUXqGt3Cs+FIhihH30/Oe4jL0/2ZoEnWGOexIFVFpue0jdqJNiIvA F5Wpx+UiT5G8CWYYge5DtHI3m5qAP9UgPuck3N8xCihbsXKX4l8bdHfziaJuowief7igeQs/ WyY9FnZb0tl29dSa7PdDKFWu+B+ZnuIzsO5vWMoN6hMThTl1DxS+jc7ATQRb/8z6AQgAvSkg 5w7dVCSbpP6nXc+i8OBz59aq8kuL3YpxT9RXE/y45IFUVuSc2kuUj683rEEgyD7XCf4QKzOw +XgnJcKFQiACpYAowhF/XNkMPQFspPNM1ChnIL5KWJdTp0DhW+WBeCnyCQ2pzeCzQlS/qfs3 dMLzzm9qCDrrDh/aEegMMZFO+reIgPZnInAcbHj3xUhz8p2dkExRMTnLry8XXkiMu9WpchHy XXWYxXbMnHkSRuT00lUfZAkYpMP7La2UudC/Uw9WqGuAQzTqhvE1kSQe0e11Uc+PqceLRHA2 bq/wz0cGriUrcCrnkzRmzYLoGXQHqRuZazMZn2/pSIMZdDxLbwARAQABwsGNBBgBCAAgFiEE JNYm8lO+nofmzlv0j/S40nFnVScFAlv/zPoCGwwAIQkQj/S40nFnVScWIQQk1ibyU76eh+bO W/SP9LjScWdVJ/g6EACFYk+OBS7pV9KZXncBQYjKqk7Kc+9JoygYnOE2wN41QN9Xl0Rk3wri qO7PYJM28YjK3gMT8glu1qy+Ll1bjBYWXzlsXrF4szSqkJpm1cCxTmDOne5Pu6376dM9hb4K l9giUinI4jNUCbDutlt+Cwh3YuPuDXBAKO8YfDX2arzn/CISJlk0d4lDca4Cv+4yiJpEGd/r BVx2lRMUxeWQTz+1gc9ZtbRgpwoXAne4iw3FlR7pyg3NicvR30YrZ+QOiop8psWM2Fb1PKB9 4vZCGT3j2MwZC50VLfOXC833DBVoLSIoL8PfTcOJOcHRYU9PwKW0wBlJtDVYRZ/CrGFjbp2L eT2mP5fcF86YMv0YGWdFNKDCOqOrOkZVmxai65N9d31k8/O9h1QGuVMqCiOTULy/h+FKpv5q t35tlzA2nxPOX8Qj3KDDqVgQBMYJRghZyj5+N6EKAbUVa9Zq8xT6Ms2zz/y7CPW74G1GlYWP i6D9VoMMi6ICko/CXUZ77OgLtMsy3JtzTRbn/wRySOY2AsMgg0Sw6yJ0wfrVk6XAMoLGjaVt X4iPTvwocEhjvrO4eXCicRBocsIB2qZaIj3mlhk2u4AkSpkKm9cN0KWYFUxlENF4/NKWMK+g fGfsCsS3cXXiZpufZFGr+GoHwiELqfLEAQ9AhlrHGCKcgVgTOI6NHg== Message-ID: Date: Thu, 12 Mar 2020 19:23:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200312064817.19000-1-afzal.mohd.ma@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/03/2020 07:48, afzal mohammed wrote: > Recently all usages of setup_irq() was replaced by request_irq(). > request_irq() does a few sanity checks that were not done in > setup_irq(), if they fail irq registration will fail. One of the check > is to ensure that non-NULL dev_id is passed in the case of shared irq. > > Fix it by passing non-NULL dev_id while registering the shared irq. > > Fixes: cc2550b421aa ("clocksource: Replace setup_irq() by request_irq()") > Signed-off-by: afzal mohammed > --- > > Hi Daniel, > > i have assumed that you would not rebase your drivers/next tree & put the > SHA-id in Fixes tag. Applied, thanks -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog