Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp807049ybh; Thu, 12 Mar 2020 11:28:58 -0700 (PDT) X-Google-Smtp-Source: ADFU+vtkSUpmibDoM9ak+OPXsCF6+/mQHafvAJBFurjs/adY7FZcrGStUri7kksl9JF2RoxUzYvR X-Received: by 2002:aca:c608:: with SMTP id w8mr3816004oif.163.1584037738433; Thu, 12 Mar 2020 11:28:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584037738; cv=none; d=google.com; s=arc-20160816; b=Xzd1SiG/6whRukFcdM7mjH4dVtAiUAkUqD7sxBzglzyZOMjxlgK7RnM2A+RN8lx3gA eOUIKCJLN0vD9nrJTU8mJup46wnZSvcewEoiyFMvONU4VdRToWG3bImCbeb/g6Gg61Or 6wL4wo0U2NZ2K/L+dvxcLxQ0nwlcXwE15CgSe4h2NasfC89ROC0OEEKJtNxdOam+FUYk 1BwzJAS2csBWCUrxIWhGBZB9CYFiPQF1FCI3IBrDmQ5+krXyVcQoEYNKWaC/IIL9J6X+ sL6Izda7yeAIm3ku+4R5tFQ+LRiAYnj9MKeXy1iWrEololz8b4tAfICR+4S60jwjb4qu nRaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=JuxJ7Z8xDChrzzCB7zGTi4ix30Z2gSprxe8mqlOflC4=; b=a9/zIxJoisumT9fRc4cHSS/bbXlA5+NduUm9G6jUvDv2G+kHsL4YcElmt46DUi2feb EZuchEbvdtusxmMbWtHGjOIpSVtYOuQjIjlCsT9AzwUoBoJKLj8x5oy9c3u10lYH5HiG AuFa70weBce2z057QOQ4BdSz+KZ/2byPIgqJISCOSc1rMzcaVk+xi4HNNHCu6XNM8ao4 lIwHqwFYE468yZ2FZjotpjR//eR1K2luRCGZww/Rbzq3z8RSoRujKqdzR2s/vUHBHthQ sEDGXVEjO+XBWVGmioar9en27LAvzcFxKBtiPWQ8KHEmWYAhQYLV1Qto3/qmNLSBNwkS gQQA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=qEixyka2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w7si3052719otm.256.2020.03.12.11.28.45; Thu, 12 Mar 2020 11:28:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=qEixyka2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726738AbgCLS1U (ORCPT + 99 others); Thu, 12 Mar 2020 14:27:20 -0400 Received: from mail-qk1-f193.google.com ([209.85.222.193]:43721 "EHLO mail-qk1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726692AbgCLS1U (ORCPT ); Thu, 12 Mar 2020 14:27:20 -0400 Received: by mail-qk1-f193.google.com with SMTP id x1so3065872qkx.10 for ; Thu, 12 Mar 2020 11:27:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=JuxJ7Z8xDChrzzCB7zGTi4ix30Z2gSprxe8mqlOflC4=; b=qEixyka206vrRdeAV/u+7hfIPOtZxqQvwSbHupJXY9nmsBSrzOl45ME2lgszt1VrSc fFT/JSNGoJB45Qwc5TVok8llXqbHzLRD8gczEsxdEQ9x1pQ9bWTpg5KFdSR8XLjJkDsT pZy6ftB92RX8A2DG3h7cKtAaElNxcx0WdZotTjWeitv/rNS9vkj0v6sgJx8GlIkMqVLX v94A8xVhZ1RcnCSbZDhT0hIrGKrK4/xSMvajPNmRWjuaf+YKarlrWzhdWptSqcROK47g Mon4ELYq+q7X4TmVftIAFL1+1n9sdTXZGIIXunmlVd198rU09cPgFEzYuLE10+eabWw8 A9Cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=JuxJ7Z8xDChrzzCB7zGTi4ix30Z2gSprxe8mqlOflC4=; b=pVnvHqJZfRkA2i3e0kbqOv1AAdm2NGvJKmUV6t3PPlq31wnYD6Yf0s/qPK44mDmfd1 0kYI4rP37+lgOpPogNEDTg9wOEjJE2ZEbDiy3qJ+OTq3BisdD+vwZtU2nx70gb50hHro agMVoywxBa7XuhybH25VqiyB5yVQhhuOx4ZnDF6ZvmpvKoJlb06t2+HmgKCSEbufgwHa rG5oKAIt6LkP01etSQ32aj/F+Ks4HKTOJVdFSva7s+q5TYKB0WDT1jjNSUZ21l3k2YLt KhNv37v2gsIEqsbmoFEtk7sK7GFFlv2tMw4FIVF8jm+l6chELRuzlshgB8Q2BMJJ3Oop eMqQ== X-Gm-Message-State: ANhLgQ3guZyn1lhTGaueClzgmBz/n4yuvmdGWux9wUpbEsNvm3KjAEao neFfDgVktTOeHl9OlDMYSYM9UqoCu1A= X-Received: by 2002:a05:620a:228f:: with SMTP id o15mr9199167qkh.197.1584037639272; Thu, 12 Mar 2020 11:27:19 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::fec8]) by smtp.gmail.com with ESMTPSA id x9sm13920350qtk.7.2020.03.12.11.27.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2020 11:27:18 -0700 (PDT) Date: Thu, 12 Mar 2020 14:27:17 -0400 From: Tejun Heo To: Chris Wilson Cc: linux-kernel@vger.kernel.org, Lai Jiangshan Subject: Re: [PATCH] workqueue: Mark up unlocked access to wq->first_flusher Message-ID: <20200312182717.GF79873@mtj.duckdns.org> References: <20200310162319.10138-1-chris@chris-wilson.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200310162319.10138-1-chris@chris-wilson.co.uk> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 10, 2020 at 04:23:19PM +0000, Chris Wilson wrote: > [ 7329.671518] BUG: KCSAN: data-race in flush_workqueue / flush_workqueue > [ 7329.671549] > [ 7329.671572] write to 0xffff8881f65fb250 of 8 bytes by task 37173 on cpu 2: > [ 7329.671607] flush_workqueue+0x3bc/0x9b0 (kernel/workqueue.c:2844) > [ 7329.672527] > [ 7329.672540] read to 0xffff8881f65fb250 of 8 bytes by task 37175 on cpu 0: > [ 7329.672571] flush_workqueue+0x28d/0x9b0 (kernel/workqueue.c:2835) > > Signed-off-by: Chris Wilson > Cc: Tejun Heo > Cc: Lai Jiangshan Applied to wq/for-5.7. Thanks. -- tejun