Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp933360ybh; Thu, 12 Mar 2020 13:50:42 -0700 (PDT) X-Google-Smtp-Source: ADFU+vugmiIGm3zFeu/0QvnR77m+Pz2xr4AzQll4GR0Hagc90UTQAny9fATPlSNs0whi6jfvEjfh X-Received: by 2002:aca:5e03:: with SMTP id s3mr4023544oib.99.1584046242661; Thu, 12 Mar 2020 13:50:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584046242; cv=none; d=google.com; s=arc-20160816; b=lhB6n3H2KvHNiaxE6O/3O3XpbOcDuqJn4QLFSq9Hb+WpGS9BD3koyONTQkcSREqVGk WFvr5nBdOvQVoOt1qdpxt/5t6bH0NpyWhY6dze5kfrevjRbgqJJxbiHdn3ZNZNdprJ0A zgk/d+ObQo+vqm9+hByC9oY9ZWPZck8j0kthCtVu5BmBiWbLTOw2CMhrg5s8i+srLGWG OECPdNt2vlsLP+lbZCtoEWV6P2KksSrJjhu9q2cB0cyvwcaBQ0K2hWe8yAxF1DD1Liuh uu1/9nKrsK4MKHoO8noBBJcWlvIlgqcZ/dw0qSuZPZ+b+RisQAIjhpvVaZEzdJi9AiK0 rW9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=YhXbw8NVfLqSGoSoG6Od4uLF4r8ozbWGxxakkHJ5MCg=; b=T02b6g81w5kaYbJLs42uM89QZ7+r7K/WCMWcRu+bpdv15wTvWiONekjlaXDiWqDo9S ozJtuNKdK89dgDRXhB05SfAy6KshWQZWssuQ5YnYZkTmKVdDZZ//rdB3CWVPqY08ftop IuaoU2mzwgC0Dn/yqDsBkwCoZCJbGkOAYmMReGfVAMPXI9SXqXe8WtXUkDd+iofQBgWZ gTqFDLRIl7XaN/K+f4PZd1Aohcd0/SVZZZd7Y1bi1yDqRG4/QnXhTStd3+7BRwYGhm1p /3h9E0sJoL2cEn52x3PRPohf5+6kbRo5vevAQh6RT7+7f15hC6JLKLqFlAZdb25VHt5Z rhew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=lIckHMDz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p20si3525328otk.258.2020.03.12.13.50.30; Thu, 12 Mar 2020 13:50:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=lIckHMDz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727141AbgCLUuE (ORCPT + 99 others); Thu, 12 Mar 2020 16:50:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:39374 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726594AbgCLUuE (ORCPT ); Thu, 12 Mar 2020 16:50:04 -0400 Received: from kicinski-fedora-PC1C0HJN (unknown [163.114.132.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 52902206B7; Thu, 12 Mar 2020 20:50:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584046203; bh=0ESAIznOWga4wawTrvGnzWr/1q5biUSHC0niGOJhISE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lIckHMDzulL89kpqtlSUe6FDaaaHagCqfTj9f1FIiEiQMjiYN1p4A1vPWKc/stdTU U1o8Ph4iU0efkmodsDb26XU0sucDb521ao7Yr72BJ7neP2pUM4npHQ+VUcnA5T6hIU RSi0PhgeMeatGn4WFCbqMKifihzIQzZXo0GiIyTU= Date: Thu, 12 Mar 2020 13:50:01 -0700 From: Jakub Kicinski To: Michal Kubecek Cc: David Miller , netdev@vger.kernel.org, Jiri Pirko , Andrew Lunn , Florian Fainelli , John Linville , Johannes Berg , linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2 11/15] ethtool: set device ring sizes with RINGS_SET request Message-ID: <20200312135001.36703aac@kicinski-fedora-PC1C0HJN> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 12 Mar 2020 21:08:28 +0100 (CET) Michal Kubecek wrote: > Implement RINGS_SET netlink request to set ring sizes of a network device. > These are traditionally set with ETHTOOL_SRINGPARAM ioctl request. > > Like the ioctl implementation, the generic ethtool code checks if supplied > values do not exceed driver defined limits; if they do, first offending > attribute is reported using extack. > > v2: > - fix netdev reference leak in error path (found by Jakub Kicinsky) > > Signed-off-by: Michal Kubecek Reviewed-by: Jakub Kicinski