Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: n7gYmNfD0at/5glFrQ+5YeLiGt5yjXpfafJF2/u7pC+WdBYA8swcJUhMFhDifsA6htqt0AIZCh
 9H3hCXMi2BVwt8L5B4PtDQTnLYhHES7v21tTwoklx54Asbw5ISzjQt/6aJgMfAU2EfJ6Fr2UKK
 pu7hYQ8hUk+Ai/ZmRSBuIb/RykbJkZLICXoK/BfhhFaS/LSV3C27sAAj/oeiC5/n/mI2V4ipQx
 rBBWVkszx9npRYAhApQ0zJ7b0wDdVpF+pgmJEbH4oZWj9eQrFHr+VF2eBDf0JIS+i8qqL7HUJZ
 Zsc=
From:   Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To:     Dongli Zhang <dongli.zhang@oracle.com>,
        "axboe@kernel.dk" <axboe@kernel.dk>
CC:     "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH for-5.7/drivers v2 1/1] null_blk: describe the usage of
 fault injection param
Thread-Topic: [PATCH for-5.7/drivers v2 1/1] null_blk: describe the usage of
 fault injection param
Thread-Index: AQHV+Lm+xkqnqrA25kGEwM3DXf6UIg==
Date:   Thu, 12 Mar 2020 22:19:55 +0000
Message-ID: <BYAPR04MB574995F3D16CABE85CF6182E86FD0@BYAPR04MB5749.namprd04.prod.outlook.com>
References: <20200312220140.12233-1-dongli.zhang@oracle.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 2bae6383-ec4a-4ee8-162e-08d7c6d37e42
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Mar 2020 22:19:55.3744
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: TZ/60CT/XXOd//jDLNH+MfpC4UouuuKIdFV00V/7mJZQSOJDhRXs+38rXWGfv+nVaepvRvkkbFOhFdLmd/s7J8Bomfr8WqvxtRy5lic9xuw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR04MB5639
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

NVMe does have the same format in host/fault_inject.c.=0A=
=0A=
This description matches what we have in :-=0A=
=0A=
null_setup_fault=0A=
	__null_setup_fault()=0A=
		setup_fault_attr()=0A=
=0A=
looks good to me.=0A=
=0A=
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>=0A=
=0A=
On 03/12/2020 03:01 PM, Dongli Zhang wrote:=0A=
> As null_blk is a very good start point to test block layer, this patch=0A=
> adds description and comments to 'timeout', 'requeue' and 'init_hctx' to=
=0A=
> explain how to use fault injection with null_blk.=0A=
>=0A=
> The nvme has similar with nvme_core.fail_request in the form of comment.=
=0A=
>=0A=
> Signed-off-by: Dongli Zhang<dongli.zhang@oracle.com>=0A=
=0A=