Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 12 Mar 2020 15:32:52 -0700 (PDT)
Message-Id: <20200312.153252.145444897248947088.davem@davemloft.net>
To:     mkubecek@suse.cz
Cc:     kuba@kernel.org, netdev@vger.kernel.org, jiri@resnulli.us,
        andrew@lunn.ch, f.fainelli@gmail.com, linville@tuxdriver.com,
        johannes@sipsolutions.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 00/15] ethtool netlink interface, part 3
From:   David Miller <davem@davemloft.net>
In-Reply-To: <cover.1584043144.git.mkubecek@suse.cz>
References: <cover.1584043144.git.mkubecek@suse.cz>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Michal Kubecek <mkubecek@suse.cz>
Date: Thu, 12 Mar 2020 21:07:33 +0100 (CET)

> Implementation of more netlink request types:
> 
>   - netdev features (ethtool -k/-K, patches 3-6)
>   - private flags (--show-priv-flags / --set-priv-flags, patches 7-9)
>   - ring sizes (ethtool -g/-G, patches 10-12)
>   - channel counts (ethtool -l/-L, patches 13-15)
> 
> Patch 1 is a style cleanup suggested in part 2 review and patch 2 updates
> the mapping between netdev features and legacy ioctl requests (which are
> still used by ethtool for backward compatibility).
> 
> Changes in v2:
>   - fix netdev reference leaks in error path of ethnl_set_rings() and
>     ethnl_set_channels() (found by Jakub Kicinski)
>   - use __set_bit() rather than set_bit() (suggested by David Miller)
>   - in replies to RINGS_GET and CHANNELS_GET requests, omit ring and
>     channel types not supported by driver/device (suggested by Jakub
>     Kicinski)
>   - more descriptive message size calculations in rings_reply_size() and
>     channels_reply_size() (suggested by Jakub Kicinski)
>   - coding style cleanup (suggested by Jakub Kicinski)

Series applied, thanks Michal.