Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 12 Mar 2020 15:43:36 -0700 (PDT)
Message-Id: <20200312.154336.1295319497057805539.davem@davemloft.net>
To:     antoine.tenart@bootlin.com
Cc:     andrew@lunn.ch, f.fainelli@gmail.com, hkallweit1@gmail.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 2/3] net: phy: mscc: split the driver into
 separate files
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20200312221033.777437-3-antoine.tenart@bootlin.com>
References: <20200312221033.777437-1-antoine.tenart@bootlin.com>
        <20200312221033.777437-3-antoine.tenart@bootlin.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Antoine Tenart <antoine.tenart@bootlin.com>
Date: Thu, 12 Mar 2020 23:10:32 +0100

> +inline int vsc8584_macsec_init(struct phy_device *phydev)
> +{
> +	return 0;
> +}
> +inline void vsc8584_handle_macsec_interrupt(struct phy_device *phydev)
> +{
> +}
> +inline void vsc8584_config_macsec_intr(struct phy_device *phydev)
> +{
> +}

Please use "static inline", as otherwise if this file is included multiple times it
will cause the compiler to emit potentially two uninlined copies which will result
in a linking error.