Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 13 Mar 2020 01:00:53 +0000
From:   Luis Chamberlain <mcgrof@kernel.org>
To:     NeilBrown <neilb@suse.de>
Cc:     Eric Biggers <ebiggers@kernel.org>, linux-kernel@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, Alexei Starovoitov <ast@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jeff Vander Stoep <jeffv@google.com>,
        Jessica Yu <jeyu@kernel.org>,
        Kees Cook <keescook@chromium.org>, NeilBrown <neilb@suse.com>,
        stable@vger.kernel.org
Subject: Re: [PATCH v2 2/4] fs/filesystems.c: downgrade user-reachable
 WARN_ONCE() to pr_warn_once()
Message-ID: <20200313010053.GS11244@42.do-not-panic.com>
References: <20200312202552.241885-1-ebiggers@kernel.org>
 <20200312202552.241885-3-ebiggers@kernel.org>
 <87imj9teh5.fsf@notabene.neil.brown.name>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="ADZbWkCsHQ7r3kzd"
Content-Disposition: inline
In-Reply-To: <87imj9teh5.fsf@notabene.neil.brown.name>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--ADZbWkCsHQ7r3kzd
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Mar 13, 2020 at 09:06:46AM +1100, NeilBrown wrote:
> On Thu, Mar 12 2020, Eric Biggers wrote:
>=20
> > From: Eric Biggers <ebiggers@google.com>
> >
> > After request_module(), nothing is stopping the module from being
> > unloaded until someone takes a reference to it via try_get_module().
> >
> > The WARN_ONCE() in get_fs_type() is thus user-reachable, via userspace
> > running 'rmmod' concurrently.
> >
> > Since WARN_ONCE() is for kernel bugs only, not for user-reachable
> > situations, downgrade this warning to pr_warn_once().
> >
> > Cc: stable@vger.kernel.org
> > Cc: Alexei Starovoitov <ast@kernel.org>
> > Cc: Andrew Morton <akpm@linux-foundation.org>
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Cc: Jeff Vander Stoep <jeffv@google.com>
> > Cc: Jessica Yu <jeyu@kernel.org>
> > Cc: Kees Cook <keescook@chromium.org>
> > Cc: Luis Chamberlain <mcgrof@kernel.org>
> > Cc: NeilBrown <neilb@suse.com>
> > Signed-off-by: Eric Biggers <ebiggers@google.com>
> > ---
> >  fs/filesystems.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/fs/filesystems.c b/fs/filesystems.c
> > index 77bf5f95362da..90b8d879fbaf3 100644
> > --- a/fs/filesystems.c
> > +++ b/fs/filesystems.c
> > @@ -272,7 +272,9 @@ struct file_system_type *get_fs_type(const char *na=
me)
> >  	fs =3D __get_fs_type(name, len);
> >  	if (!fs && (request_module("fs-%.*s", len, name) =3D=3D 0)) {
> >  		fs =3D __get_fs_type(name, len);
> > -		WARN_ONCE(!fs, "request_module fs-%.*s succeeded, but still no fs?\n=
", len, name);
> > +		if (!fs)
> > +			pr_warn_once("request_module fs-%.*s succeeded, but still no fs?\n",
> > +				     len, name);
>=20
> I strongly support the replacement of "WARN" by "pr_warn".
> I wonder if we really want the "once" now.  Possibly using rate_limited
> would be justified, but I think that in general we should see a warning
> every time this event happens.

Since the usefulness of the print is at boot, I think pr_warn_once() is
good right now but just because I cannot think of a case where multiple
prints are currently desirable, or where this should be possible
post-boot. Can you?

  Luis

--ADZbWkCsHQ7r3kzd
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEENnNq2KuOejlQLZofziMdCjCSiKcFAl5q20EACgkQziMdCjCS
iKfnAg//YO6054oZ2BeLdkU7iF2nNMAvYEsJb8/1UxyS+6T/oJ7tB6qkkURs5oky
sJtxPgUtlqS+PA1K7x+VE62/FLFAeMxX6nHx6aSUWUvD2lm4cDSegjSDW2ChUrF1
GiHt0EmSjYuzNkHfTfnsLO2sUY8ZnaLqfLoDOPiFlf7KCskTqtE7JR5UfXflNe+B
snXXpxQY7zvljIjw6ylB3I6dSHX4b7NML/74P+NlQH/hGadPQ6oGi5xG9T/cwEJ3
57aaHndOtS2XIvR8ilueemewZuxnRwWxNJYwPF4XUKO8gqFTzqQMLtaPfvzcpoj9
KqfNj24/XGyYxluCL/OS5YE9Y6/aStM9eppN4Ycy9c5RxdIWCNer7aGPyqvU9Hya
Mt20u7x25eOMORti72qQEQaDCDCdAq8cB1glqJpF8HyixRUaAJcCeDyK0PbJHoDz
IbQ2P0nR8evgx/H2SaETdRpaGDU9zZ7/HOYiAg5OuF3pBiTHiIFrMqHc19eAo8Oy
tnsowlCCAAx16D7CIYHuF4dGKaiPja/78UPyx1lVZVaqWObuZaFBM5sO1HRFGAPv
wEsCL4038eqNrAkdxFIeZPEyr8C+JC32OmptqlGQIG1XY1dWIiGtlNARvvFG/tVg
gOIoSdRk9QQVfjEK7NUvfw6pxYFoGt/GGssIY75Me5AfqBW/5fc=
=dx47
-----END PGP SIGNATURE-----

--ADZbWkCsHQ7r3kzd--