Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp1143756ybh; Thu, 12 Mar 2020 18:12:06 -0700 (PDT) X-Google-Smtp-Source: ADFU+vvJSE09Qh9PDJIYDOCj94Z+KQKPwWdpVDRUHE//aHwriMf+/WxSqXhWS0Soiy37fJCWQq8s X-Received: by 2002:aca:b9d6:: with SMTP id j205mr5130335oif.179.1584061926800; Thu, 12 Mar 2020 18:12:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584061926; cv=none; d=google.com; s=arc-20160816; b=VW5TxrZ4CnANsraFNn7qJKB0unriggNe5JRDvGWgUFsIQMgQqUh/uz4gJ6b1faeFLl UcQrGCeHKgXrysgKAOsUarbTJKnsSYoGl7PHBawjUXoydOasj6hPcL/nm/M+x7PyRHlj pBFzgMnNo9PivodXGNaDt1YktcM1i5VDezKrq/XnDrP5OBgaPebkqHYR1KwKiX6McRH5 80G1SbRGrnKV/0WdtLHIaze2WxWzv/0zhe1FWbeoyAKAMEowvCQx1hZ+1t7Cu1DXIy8E LVGlhM/KzMYawZaT1ugHi4FOk0Rqp/gkSu8aRrY5nxT4PACun+VIC7IK13P8/xWgOKAu 5k5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=CcNfF/07Ka3CUKQ7ilr3WgFQQ1ag9rweL4Pv+Qvg4K8=; b=EZD3TDPxut3bCVJ+hk9HCvr0aSy+oG34Szs8CJzOKrUGdVy5KMAeCerBwOzXKCojOQ 8Y1s765ipVC/fencSh241k1bFjnV/QiQHEujehP2THbcSM6fPT/67KisuIw8asa63o2B Mjyt8RUeT8GQt1RmjLBB88e9D3DRXHiICSZz3s/2pFdq3xg9cMvTXCD4ToN8SU02K6Lc CBUfmaixvZwmcjnLTDI8LBuVUmuGwn5WUobl5v1NZ5iK0FOdXy7eiHSgh9njVk3Sq2xa WDXk9DIr2/r8ohWrzM5S5Wa5ch9e2BkmTKTRcEzj57AcVolpokszjCUrZOwKupxw2b+2 ElSw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b6si3759639otj.275.2020.03.12.18.11.54; Thu, 12 Mar 2020 18:12:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727314AbgCMBLb (ORCPT + 99 others); Thu, 12 Mar 2020 21:11:31 -0400 Received: from 97-93-29-23.dhcp.snlo.ca.charter.com ([97.93.29.23]:54446 "EHLO skomatineni-linux.nvidia.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727027AbgCMBL0 (ORCPT ); Thu, 12 Mar 2020 21:11:26 -0400 Received: by skomatineni-linux.nvidia.com (Postfix, from userid 1000) id 42B071040069; Mon, 9 Mar 2020 17:13:27 -0700 (PDT) From: Sowjanya Komatineni To: adrian.hunter@intel.com, ulf.hansson@linaro.org, baolin.wang@linaro.org, kstewart@linuxfoundation.org, tglx@linutronix.de, bradleybolen@gmail.com, gregkh@linuxfoundation.org, thierry.reding@gmail.com, jonathanh@nvidia.com Cc: skomatineni@nvidia.com, anrao@nvidia.com, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org Subject: [PATCH v1 2/3] mmc: tegra: Implement HW busy wait timeout based on command busy time Date: Mon, 9 Mar 2020 17:13:24 -0700 Message-Id: <1583799205-8442-2-git-send-email-skomatineni@nvidia.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1583799205-8442-1-git-send-email-skomatineni@nvidia.com> References: <1583799205-8442-1-git-send-email-skomatineni@nvidia.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Tegra host supports HW busy detection and timeouts based on the count programmed in SDHCI_TIMEOUT_CONTROL register and max busy timeout it supports is 11s in finite busy wait mode. Some operations like SLEEP_AWAKE, ERASE and flush cache through SWITCH commands take longer than 11s and Tegra host supports infinite HW busy wait mode where HW waits forever till the card is busy without HW timeout. This patch implements Tegra specific set_timeout sdhci_ops to allow switching between finite and infinite HW busy detection wait modes based on the device command expected operation time. Signed-off-by: Sowjanya Komatineni --- drivers/mmc/host/sdhci-tegra.c | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+) diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c index 403ac44..40a221d 100644 --- a/drivers/mmc/host/sdhci-tegra.c +++ b/drivers/mmc/host/sdhci-tegra.c @@ -45,6 +45,7 @@ #define SDHCI_TEGRA_CAP_OVERRIDES_DQS_TRIM_SHIFT 8 #define SDHCI_TEGRA_VENDOR_MISC_CTRL 0x120 +#define SDHCI_MISC_CTRL_ERASE_TIMEOUT_LIMIT BIT(0) #define SDHCI_MISC_CTRL_ENABLE_SDR104 0x8 #define SDHCI_MISC_CTRL_ENABLE_SDR50 0x10 #define SDHCI_MISC_CTRL_ENABLE_SDHCI_SPEC_300 0x20 @@ -1227,6 +1228,34 @@ static u32 sdhci_tegra_cqhci_irq(struct sdhci_host *host, u32 intmask) return 0; } +static void tegra_sdhci_set_timeout(struct sdhci_host *host, + struct mmc_command *cmd) +{ + u32 val; + + /* + * HW busy detection timeout is based on programmed data timeout + * counter and maximum supported timeout is 11s which may not be + * enough for long operations like cache flush, sleep awake, erase. + * + * ERASE_TIMEOUT_LIMIT bit of VENDOR_MISC_CTRL register allows + * host controller to wait for busy state until the card is busy + * without HW timeout. + * + * So, use infinite busy wait mode for operations that may take + * more than maximum HW busy timeout of 11s otherwise use finite + * busy wait mode. + */ + val = sdhci_readl(host, SDHCI_TEGRA_VENDOR_MISC_CTRL); + if (cmd && cmd->busy_timeout >= 11 * HZ) + val |= SDHCI_MISC_CTRL_ERASE_TIMEOUT_LIMIT; + else + val &= ~SDHCI_MISC_CTRL_ERASE_TIMEOUT_LIMIT; + sdhci_writel(host, val, SDHCI_TEGRA_VENDOR_MISC_CTRL); + + __sdhci_set_timeout(host, cmd); +} + static const struct cqhci_host_ops sdhci_tegra_cqhci_ops = { .write_l = tegra_cqhci_writel, .enable = sdhci_tegra_cqe_enable, @@ -1366,6 +1395,7 @@ static const struct sdhci_ops tegra210_sdhci_ops = { .set_uhs_signaling = tegra_sdhci_set_uhs_signaling, .voltage_switch = tegra_sdhci_voltage_switch, .get_max_clock = tegra_sdhci_get_max_clock, + .set_timeout = tegra_sdhci_set_timeout, }; static const struct sdhci_pltfm_data sdhci_tegra210_pdata = { @@ -1403,6 +1433,7 @@ static const struct sdhci_ops tegra186_sdhci_ops = { .voltage_switch = tegra_sdhci_voltage_switch, .get_max_clock = tegra_sdhci_get_max_clock, .irq = sdhci_tegra_cqhci_irq, + .set_timeout = tegra_sdhci_set_timeout, }; static const struct sdhci_pltfm_data sdhci_tegra186_pdata = { -- 2.7.4