Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp1223718ybh; Thu, 12 Mar 2020 20:04:05 -0700 (PDT) X-Google-Smtp-Source: ADFU+vtABfN67x07a+wX3uNdjov7/PLeTCnuqMBwxSysxbxHtH04FGgCx7nAGrhA+9PK0JrJEYM2 X-Received: by 2002:a9d:4c99:: with SMTP id m25mr2795158otf.187.1584068645371; Thu, 12 Mar 2020 20:04:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584068645; cv=none; d=google.com; s=arc-20160816; b=ZBcTurJo/TjxZqeN0udqpDtHVPOgXaXPgPgkPcUTtnqawXWMtlO61xmn1y2SNnE46+ jgdp4AJSDDbojuaWKavTxFI8hIIbE5n0cIOUrI6YFfqnF5XTb11m1uJZM+BYnm2gxXuU wgfYcO1gtAFeDSiYG5xou1wvwdV5n2M5FRuJVeIJlnY6jNGwUwoeU1g3geSm1EmJhwAT n9ZsL8sqB1Dv3QdMivKXHN1AlIOB/E2Kl03qOvGRgLwCzEHjgYMhgsp6RdvdiZ++45yy YnlIot1Fg+Z1KjuVSUchqNEaglb6TIZOR+Gpsb0U1srrrMge9pyf09mZXnJhNuQUw+R+ sDgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=TtGN0IKhKTP+FkbINXRmNXL4VgVFcSAOPibOleZYcWM=; b=gzUoqXssyf1IoVXzYwy8UGlSNNsmFigVR53G4KCaPlipDT4TPPtwQ2v0a4sx7SPLQ/ TxpjNlyPHXQipARPBRhO799Vsl/IHmQcFVPBTgLnc87NrXLvw2/ZiJ7qRyfp3wiSCWX7 Mj1pyzcvIahK31VeqzKTGJ27WMNUrxxIrdF8V2NMBYMq8mY4oJHTtOs7f90ilHfSVl5k 8svvllLUJ2TU1dN0D4l5JtOtEe+mUjniL4aYgtv9292RYpxS0fsGj1dHTtXEWS7+jBnz MOvFZxx3HmkH5v8V0Lv1Uczkr3lOgIJNwGfbUv9KAhQoncHLMuk5T9ZNFUB4SSbVXmGU PY2g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ugq8qbdw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u24si3832226otk.287.2020.03.12.20.03.52; Thu, 12 Mar 2020 20:04:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ugq8qbdw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726390AbgCMDDB (ORCPT + 99 others); Thu, 12 Mar 2020 23:03:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:60544 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726246AbgCMDDB (ORCPT ); Thu, 12 Mar 2020 23:03:01 -0400 Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 569AD206E2; Fri, 13 Mar 2020 03:03:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584068580; bh=MfD/el5E9LurZZaSPewSeycv8wSAS3R57zWeVs/eDn0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ugq8qbdwRlDRYUE6VABOfQoKJks/BvDS0ZkVWlcSotdEyl45bnMZYGGR3reqsLd2K JHMz8OZMqnVoVhqLQQhKH8duhDQ+/D953aeF+bYMCVtpNZsHvTrhFFrVPZA2uzcO1O QuLTbMLJhLKH0/gThuELJJu+AOsf/e0BA5KUj1ag= Date: Thu, 12 Mar 2020 20:02:59 -0700 From: Andrew Morton To: Jaewon Kim Cc: willy@infradead.org, walken@google.com, bp@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org, jaewon31.kim@gmail.com Subject: Re: [PATCH v2 1/2] mmap: remove inline of vm_unmapped_area Message-Id: <20200312200259.7b79b38341bde97609fde99a@linux-foundation.org> In-Reply-To: <20200313011420.15995-2-jaewon31.kim@samsung.com> References: <20200313011420.15995-1-jaewon31.kim@samsung.com> <20200313011420.15995-2-jaewon31.kim@samsung.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 13 Mar 2020 10:14:19 +0900 Jaewon Kim wrote: > In prepration for next patch remove inline of vm_unmapped_area and move > code to mmap.c. There is no logical change. > > Also remove unmapped_area[_topdown] out of mm.h, there is no code > calling to them. > Patches seem reasonable. > -extern unsigned long unmapped_area(struct vm_unmapped_area_info *info); > -extern unsigned long unmapped_area_topdown(struct vm_unmapped_area_info *info); I believe these can now be made static to mmap.c