Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Peter Chen <peter.chen@nxp.com>
To:     Mark Brown <broonie@kernel.org>
CC:     "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH 1/1] regulator: fixed: add system pm routines for pinctrl
Thread-Topic: [PATCH 1/1] regulator: fixed: add system pm routines for pinctrl
Thread-Index: AQHV+FpZgufkrsn3KkuJmHgdNm1nAKhE1zoAgAAUhICAABsJgIAAB0wAgAABBgCAAMmjgA==
Date:   Fri, 13 Mar 2020 03:08:48 +0000
Message-ID: <20200313030851.GI14625@b29397-desktop>
References: <20200312103804.24174-1-peter.chen@nxp.com>
 <20200312114712.GA4038@sirena.org.uk> <20200312130037.GG14625@b29397-desktop>
 <20200312143723.GF4038@sirena.org.uk> <20200312150330.GH14625@b29397-desktop>
 <20200312150710.GG4038@sirena.org.uk>
In-Reply-To: <20200312150710.GG4038@sirena.org.uk>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-ID: <7857552FA995FB4AA07CA7F99A6EEA02@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 4211b07c-136f-4932-7e8e-08d7c6fbd97e
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Mar 2020 03:08:48.1802
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: gXu2RY18VIxmkjtZYlv3sOAmkrRJFCgaM89AAY9NmWQ+jC8xb99zmvfeXBR+gFokBoJBj94cB9C7neF8MtWC+A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5327
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 20-03-12 15:07:10, Mark Brown wrote:
> On Thu, Mar 12, 2020 at 03:03:26PM +0000, Peter Chen wrote:
> > On 20-03-12 14:37:23, Mark Brown wrote:
>=20
> > > Surely it's the GPIO controller that needs pinctrl support then?
>=20
> > But the pinctrl register value for this gpio will be cleared after
> > suspend, we need to restore it, otherwise, the function will be not
> > gpio. See below patch:
>=20
> I'd expect that this would be handled by the GPIO driver, the user
> shouldn't need to care.

GPIO function is just our case for this fixed regulator, other users for
this fixed regulator may set pinctrl as other functions.

Here, it is just save and restore pinctrl value for fixed regulator
driver, not related to GPIO.

--=20

Thanks,
Peter Chen=