Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v2 1/2] mmap: remove inline of vm_unmapped_area
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     willy@infradead.org, walken@google.com, bp@suse.de,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        jaewon31.kim@gmail.com
From:   Jaewon Kim <jaewon31.kim@samsung.com>
Message-ID: <5E6AFDBE.4090808@samsung.com>
Date:   Fri, 13 Mar 2020 12:27:58 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
        Thunderbird/38.7.2
MIME-Version: 1.0
In-Reply-To: <20200312200259.7b79b38341bde97609fde99a@linux-foundation.org>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 101P
DLP-Filter: Pass
References: <20200313011420.15995-1-jaewon31.kim@samsung.com>
        <CGME20200313011430epcas1p129e4033f12b9c02f71443e0b359a26e5@epcas1p1.samsung.com>
        <20200313011420.15995-2-jaewon31.kim@samsung.com>
        <20200312200259.7b79b38341bde97609fde99a@linux-foundation.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 2020년 03월 13일 12:02, Andrew Morton wrote:
> On Fri, 13 Mar 2020 10:14:19 +0900 Jaewon Kim <jaewon31.kim@samsung.com> wrote:
>
>> In prepration for next patch remove inline of vm_unmapped_area and move
>> code to mmap.c. There is no logical change.
>>
>> Also remove unmapped_area[_topdown] out of mm.h, there is no code
>> calling to them.
>>
> Patches seem reasonable.
>
>> -extern unsigned long unmapped_area(struct vm_unmapped_area_info *info);
>> -extern unsigned long unmapped_area_topdown(struct vm_unmapped_area_info *info);
> I believe these can now be made static to mmap.c
Correct.
Let me wait for the 2/2 patch to be reviewed, and resubmit this 1/2 patch with having static if need.
Thank you for your comment.
>
>
>
>