Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Peng Fan <peng.fan@nxp.com>
To:     Leonard Crestez <leonard.crestez@nxp.com>,
        "jassisinghbrar@gmail.com" <jassisinghbrar@gmail.com>,
        "o.rempel@pengutronix.de" <o.rempel@pengutronix.de>
CC:     "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        dl-linux-imx <linux-imx@nxp.com>,
        Anson Huang <anson.huang@nxp.com>,
        Aisheng Dong <aisheng.dong@nxp.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH V6 0/4] mailbox/firmware: imx: support SCU channel type
Thread-Topic: [PATCH V6 0/4] mailbox/firmware: imx: support SCU channel type
Thread-Index: AQHV8emRGg+Z0s59ZUi7vGFwjsJP+qhFwwuggABtClA=
Date:   Fri, 13 Mar 2020 07:38:31 +0000
Message-ID: <AM0PR04MB4481D74E3C38B047562F419988FA0@AM0PR04MB4481.eurprd04.prod.outlook.com>
References: <1583300977-2327-1-git-send-email-peng.fan@nxp.com>
 <VI1PR04MB7023455D0FE9766FFBE1EE5EEEFD0@VI1PR04MB7023.eurprd04.prod.outlook.com>
 <AM0PR04MB448123609B2FE8F5ECAF1F4388FA0@AM0PR04MB4481.eurprd04.prod.outlook.com>
In-Reply-To: <AM0PR04MB448123609B2FE8F5ECAF1F4388FA0@AM0PR04MB4481.eurprd04.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: d34f8c54-a4f5-4b65-cd87-08d7c7218773
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Mar 2020 07:38:31.5136
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: OcugRavhZRW8l+NZuNGR+51eDHv0mEhIR59JhYYxWiVmERhX89CWW7tQdIkTnwIpoTTUjRFtax6MR64KZkGdVw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4705
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Subject: RE: [PATCH V6 0/4] mailbox/firmware: imx: support SCU channel
> type
>=20
> Hi Leonard,
>=20
> > Subject: Re: [PATCH V6 0/4] mailbox/firmware: imx: support SCU channel
> > type
> >
> > On 2020-03-04 7:55 AM, Peng Fan wrote:
> > > From: Peng Fan <peng.fan@nxp.com>
> > >
> > > V6:
> > >   Add Oleksij's R-b tag
> > >   Patch 3/4, per
> > https://www.kernel.org/doc/Documentation/printk-formats.txt
> > >   should use %zu for printk sizeof
> > >
> > > V5:
> > >   Move imx_mu_dcfg below imx_mu_priv
> > >   Add init hooks to imx_mu_dcfg
> > >   drop __packed __aligned
> > >   Add more debug msg
> > >   code style cleanup
> > >
> > > V4:
> > >   Drop IMX_MU_TYPE_[GENERIC, SCU]
> > >   Pack MU chans init to separate function
> > >   Add separate function for SCU chans init and xlate
> > >   Add santity check to msg hdr.size
> > >   Limit SCU MU chans to 6, TX0/RX0/RXDB[0-3]
> > >
> > > V3:
> > >   Rebase to Shawn's for-next
> > >   Include fsl,imx8-mu-scu compatible
> > >   Per Oleksij's comments, introduce generic tx/rx and added scu mu ty=
pe
> > >   Check fsl,imx8-mu-scu in firmware driver for fast_ipc
> > >
> > > V2:
> > >   Drop patch 1/3 which added fsl,scu property
> > >   Force to use scu channel type when machine has node compatible
> > "fsl,imx-scu"
> > >   Force imx-scu to use fast_ipc
> > >
> > >   I not found a generic method to make SCFW message generic enough,
> > SCFW
> > >   message is not fixed length including TX and RX. And it use TR0/RR0
> > >   interrupt.
> > >
> > > V1:
> > > Sorry to bind the mailbox/firmware patch together. This is make it
> > > to understand what changed to support using 1 TX and 1 RX channel
> > > for SCFW message.
> > >
> > > Per i.MX8QXP Reference mannual, there are several message using
> > > examples. One of them is:
> > > Passing short messages: Transmit register(s) can be used to pass
> > > short messages from one to four words in length. For example, when a
> > > four-word message is desired, only one of the registers needs to
> > > have its corresponding interrupt enable bit set at the receiver side.
> > >
> > > This patchset is to using this for SCFW message to replace four TX
> > > and four RX method.
> >
> > Tested-by: Leonard Crestez <leonard.crestez@nxp.com>
> >
>=20
> Thanks for the test.
>=20
> > My stress tests pass on imx8qxp with this patcheset, however
> > performance is not greatly improved. My guess is that this happens
> > because of too many interrupts.
>=20
> Might be. Could you share your testcase?
>=20
> >
> > Is there really a reason to enable TIE? Spinning on TE bits without
> > any interrupts should be just plain faster.
>=20
> I could try to disable TIE and give a try. If performance improves lot, I=
 could
> change to non TX interrupt.

After rethinking about this, we need TX interrupt, otherwise we have to
use TX_POLL which is slower or let the client kick the TX state machine.

Compared with original method, this already reduces to use 1 TX and 1 RX
interrupt. This already good for system.

Thanks,
Peng.

>=20
> Oleksij, do you agree?
>=20
> Thanks,
> Peng.
>=20
> >
> > >
> > > Peng Fan (4):
> > >    dt-bindings: mailbox: imx-mu: add SCU MU support
> > >    mailbox: imx: restructure code to make easy for new MU
> > >    mailbox: imx: add SCU MU support
> > >    firmware: imx-scu: Support one TX and one RX
> > >
> > >   .../devicetree/bindings/mailbox/fsl,mu.txt         |   2 +
> > >   drivers/firmware/imx/imx-scu.c                     |  54 ++++-
> > >   drivers/mailbox/imx-mailbox.c                      | 267
> > +++++++++++++++++----
> > >   3 files changed, 260 insertions(+), 63 deletions(-)
> > >
> > >
> > > base-commit: 770fbb32d34e5d6298cc2be590c9d2fd6069aa17
> > >