Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Peng Fan <peng.fan@nxp.com>
To:     Abel Vesa <abel.vesa@nxp.com>, Rob Herring <robh@kernel.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <kernel@pengutronix.de>,
        Fabio Estevam <fabio.estevam@nxp.com>,
        Mike Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Lee Jones <lee.jones@linaro.org>,
        Anson Huang <anson.huang@nxp.com>,
        Leonard Crestez <leonard.crestez@nxp.com>,
        Jacky Bai <ping.bai@nxp.com>
CC:     dl-linux-imx <linux-imx@nxp.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
        Abel Vesa <abel.vesa@nxp.com>
Subject: RE: [RFC 02/11] arm64: dts: imx8mp: Add AIPS 4 and 5
Thread-Topic: [RFC 02/11] arm64: dts: imx8mp: Add AIPS 4 and 5
Thread-Index: AQHV8TqlJIxDUMbhF0CTiGOzlk4moKhGM6iA
Date:   Fri, 13 Mar 2020 07:44:43 +0000
Message-ID: <AM0PR04MB44814EAE53E091499C639F3188FA0@AM0PR04MB4481.eurprd04.prod.outlook.com>
References: <1583226206-19758-1-git-send-email-abel.vesa@nxp.com>
 <1583226206-19758-3-git-send-email-abel.vesa@nxp.com>
In-Reply-To: <1583226206-19758-3-git-send-email-abel.vesa@nxp.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 90a22e50-89c5-49c8-8224-08d7c7226518
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Mar 2020 07:44:43.3475
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: nexJETpg4UQP4/k7DHUnoo60Lean89EP17GHk9fz6njgROUuSTzxVEkq5XasHKVs60D85NF3Q7V+lwpM5/AsKQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4705
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Subject: [RFC 02/11] arm64: dts: imx8mp: Add AIPS 4 and 5
>=20
> There are 5 AIPS maps in total, according to the RM. Add the missing ones
> here.
>=20
> Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/imx8mp.dtsi | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>=20
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> index 71b0c8f..a997ca7 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> @@ -603,6 +603,22 @@
>  			};
>  		};
>=20
> +		aips4: bus@32c00000 {
> +			compatible =3D "simple-bus";

"fsl,aips-bus", "simple-bus";

> +			reg =3D <0x32c00000 0x400000>;

Size is 64KB

> +			#address-cells =3D <1>;
> +			#size-cells =3D <1>;
> +			ranges;
> +		};
> +
> +		aips5: bus@30c00000 {
> +			compatible =3D "simple-bus";
> +			reg =3D <0x30c00000 0x400000>;

Ditto. Please correct compatible and reg.

Without this, I think there is no need to only
add bus here? It might be better to also include
subnodes under aips bus.

Regards,
Peng.

> +			#address-cells =3D <1>;
> +			#size-cells =3D <1>;
> +			ranges;
> +		};
> +
>  		gic: interrupt-controller@38800000 {
>  			compatible =3D "arm,gic-v3";
>  			reg =3D <0x38800000 0x10000>,
> --
> 2.7.4