Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8BIT
In-Reply-To: <20200312.154336.1295319497057805539.davem@davemloft.net>
References: <20200312221033.777437-1-antoine.tenart@bootlin.com> <20200312221033.777437-3-antoine.tenart@bootlin.com> <20200312.154336.1295319497057805539.davem@davemloft.net>
Subject: Re: [PATCH net-next v2 2/3] net: phy: mscc: split the driver into separate files
To:     David Miller <davem@davemloft.net>
Cc:     andrew@lunn.ch, f.fainelli@gmail.com, hkallweit1@gmail.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
From:   Antoine Tenart <antoine.tenart@bootlin.com>
Message-ID: <158408684876.668992.7957856749031634535@kwain>
Date:   Fri, 13 Mar 2020 09:07:29 +0100
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hello David,

Quoting David Miller (2020-03-12 23:43:36)
> From: Antoine Tenart <antoine.tenart@bootlin.com>
> Date: Thu, 12 Mar 2020 23:10:32 +0100
> 
> > +inline int vsc8584_macsec_init(struct phy_device *phydev)
> > +{
> > +     return 0;
> > +}
> > +inline void vsc8584_handle_macsec_interrupt(struct phy_device *phydev)
> > +{
> > +}
> > +inline void vsc8584_config_macsec_intr(struct phy_device *phydev)
> > +{
> > +}
> 
> Please use "static inline", as otherwise if this file is included multiple times it
> will cause the compiler to emit potentially two uninlined copies which will result
> in a linking error.

Will do.

Thanks!
Antoine

-- 
Antoine Ténart, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com