Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 13 Mar 2020 07:44:45 -0300
From:   Bruno Meneguele <bmeneg@redhat.com>
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        pmladek@suse.com, sergey.senozhatsky@gmail.com, rostedt@goodmis.org
Subject: Re: [PATCH] kernel/printk: add kmsg SEEK_CUR handling
Message-ID: <20200313104445.GH13406@glitch>
References: <20200313003533.2203429-1-bmeneg@redhat.com>
 <20200313072254.GA1960396@kroah.com>
MIME-Version: 1.0
In-Reply-To: <20200313072254.GA1960396@kroah.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="AzNpbZlgThVzWita"
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--AzNpbZlgThVzWita
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Mar 13, 2020 at 08:22:54AM +0100, Greg KH wrote:
> On Thu, Mar 12, 2020 at 09:35:33PM -0300, Bruno Meneguele wrote:
> > Userspace libraries, e.g. glibc's dprintf(), expect the default return =
value
> > for invalid seek situations: -ESPIPE, but when the IO was over /dev/kms=
g the
> > current state of kernel code was returning the generic case of an -EINV=
AL.
> > Hence, userspace programs were not behaving as expected or documented.
> >=20
> > With this patch we add SEEK_CUR case returning the expected value and a=
lso a
> > simple mention of it in kernel's documentation for those relying on tha=
t for
> > guidance.
> >=20
> > Signed-off-by: Bruno Meneguele <bmeneg@redhat.com>
> > ---
> >  Documentation/ABI/testing/dev-kmsg | 2 ++
> >  kernel/printk/printk.c             | 4 ++++
> >  2 files changed, 6 insertions(+)
>=20
> <formletter>
>=20
> This is not the correct way to submit patches for inclusion in the
> stable kernel tree.  Please read:
>     https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.ht=
ml
> for how to do this properly.
>=20
> </formletter>
>=20

ouch, yes of course. Sorry for the noise. =20
Will repost it once the concerns with the patch are solved.

Thanks Greg.

--=20
bmeneg=20
PGP Key: http://bmeneg.com/pubkey.txt

--AzNpbZlgThVzWita
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEdWo6nTbnZdbDmXutYdRkFR+RokMFAl5rZB0ACgkQYdRkFR+R
okNb7ggAxbkwFdSoQBgH0xZI1DmgLTjKi+ZL+j7MtBdujIL2f6vbCfhnK8G4nocx
SvCAk//UCsAqAkib7vCdJTwPm3QT7TmtUAtZ2dgQkooytWEKyLY5h2p/WZwg9RGV
LwA7GU66oYsCzkFIy+TSHa6DL2wsesdef1tDapiDhFKFV/tnFumx9U7JnnyZCV+m
xuUfLKAojOEYGN2T1vJTv4Phy+ru4Rw8ZRWToMHnw0lYNd2V0xnFbzoFYd76JCE9
IT4yW3eJWrngU7f/+IUUkE2MLPot3jToatuJCumKz8CzTa6lxjgX1Pzbm+wVCNBR
BffqOOOwAQyaHpiXziOW/5QCgZPikg==
=bQvY
-----END PGP SIGNATURE-----

--AzNpbZlgThVzWita--