Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 3/3] virt: vbox: Use fallthrough;
To:     Joe Perches <joe@perches.com>, Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     linux-kernel@vger.kernel.org
References: <cover.1584040050.git.joe@perches.com>
 <68773b4cd82288b78ca6fcde8c43e249a025378a.1584040050.git.joe@perches.com>
From:   Hans de Goede <hdegoede@redhat.com>
Message-ID: <eb4b9c3d-23c4-7b93-9a5d-6686947a818d@redhat.com>
Date:   Fri, 13 Mar 2020 11:45:57 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.5.0
MIME-Version: 1.0
In-Reply-To: <68773b4cd82288b78ca6fcde8c43e249a025378a.1584040050.git.joe@perches.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

On 3/12/20 8:17 PM, Joe Perches wrote:
> Convert the various uses of fallthrough comments to fallthrough;
> 
> Done via script
> Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe@perches.com/
> 
> And by hand:
> 
> drivers/virt/vboxguest/vboxguest_core.c has a fallthrough comment outside
> of an #ifdef block that causes gcc to emit a warning if converted in-place.
> 
> So move the new fallthrough; inside the containing #ifdef/#endif too.
> 
> Signed-off-by: Joe Perches <joe@perches.com>

Patch looks good to me:

Acked-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans


> ---
>   drivers/virt/vboxguest/vboxguest_core.c  | 2 +-
>   drivers/virt/vboxguest/vboxguest_utils.c | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/virt/vboxguest/vboxguest_core.c b/drivers/virt/vboxguest/vboxguest_core.c
> index d823d5..b690a8 100644
> --- a/drivers/virt/vboxguest/vboxguest_core.c
> +++ b/drivers/virt/vboxguest/vboxguest_core.c
> @@ -1553,8 +1553,8 @@ int vbg_core_ioctl(struct vbg_session *session, unsigned int req, void *data)
>   #ifdef CONFIG_COMPAT
>   	case VBG_IOCTL_HGCM_CALL_32(0):
>   		f32bit = true;
> +		fallthrough;
>   #endif
> -		/* Fall through */
>   	case VBG_IOCTL_HGCM_CALL(0):
>   		return vbg_ioctl_hgcm_call(gdev, session, f32bit, data);
>   	case VBG_IOCTL_LOG(0):
> diff --git a/drivers/virt/vboxguest/vboxguest_utils.c b/drivers/virt/vboxguest/vboxguest_utils.c
> index 50920b..739618 100644
> --- a/drivers/virt/vboxguest/vboxguest_utils.c
> +++ b/drivers/virt/vboxguest/vboxguest_utils.c
> @@ -311,7 +311,7 @@ static u32 hgcm_call_linear_addr_type_to_pagelist_flags(
>   	switch (type) {
>   	default:
>   		WARN_ON(1);
> -		/* Fall through */
> +		fallthrough;
>   	case VMMDEV_HGCM_PARM_TYPE_LINADDR:
>   	case VMMDEV_HGCM_PARM_TYPE_LINADDR_KERNEL:
>   		return VMMDEV_HGCM_F_PARM_DIRECTION_BOTH;
>