Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Fri, 13 Mar 2020 12:35:10 +0000
From:   Marc Zyngier <maz@kernel.org>
To:     Shaokun Zhang <zhangshaokun@hisilicon.com>
Cc:     linux-kernel@vger.kernel.org,
        Nianyao Tang <tangnianyao@huawei.com>,
        Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] irqchip/gic-v4: Fix non-stick page size error for setup
 GITS_BASER
In-Reply-To: <9a00642020fe660e005045913b57fd20@kernel.org>
References: <1584089195-63897-1-git-send-email-zhangshaokun@hisilicon.com>
 <9a00642020fe660e005045913b57fd20@kernel.org>
Message-ID: <02159eb7ba2667e3ddea658ff4b3cb92@kernel.org>
User-Agent: Roundcube Webmail/1.3.10
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2020-03-13 12:00, Marc Zyngier wrote:

[...]

The astute reader will have noticed that I've sent the wrong patch:

> +static int its_probe_baser_psz(struct its_node *its, struct its_baser 
> *baser)
> +{
> +	u64 psz = SZ_64K;
> +
> +	while (psz) {
> +		u64 val, gpsz;
> +
> +		val = its_read_baser(its, baser);
> +		val &= ~GITS_BASER_PAGE_SIZE_MASK;
> +
> +		switch (psz) {
> +		case SZ_64K:
> +			gpsz = GITS_BASER_PAGE_SIZE_64K;
> +			break;
> +		case SZ_16K:
> +			gpsz = GITS_BASER_PAGE_SIZE_16K;
> +			break;
> +		case SZ_4K:
> +		default:
> +			gpsz = GITS_BASER_PAGE_SIZE_4K;
> +			break;
> +		}
> +
> +		gpz >>= GITS_BASER_PAGE_SIZE_SHIFT;

s/gpz/gpsz/

Sorry for the noise,

         M.
-- 
Jazz is not dead. It just smells funny...