Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 13 Mar 2020 18:15:22 +0530
From:   afzal mohammed <afzal.mohd.ma@gmail.com>
To:     Guan Xuetao <gxt@pku.edu.cn>
Cc:     linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] unicore32: replace setup_irq() by request_irq()
Message-ID: <20200313124522.GC7225@afzalpc>
References: <20200304005137.5523-1-afzal.mohd.ma@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200304005137.5523-1-afzal.mohd.ma@gmail.com>
User-Agent: Mutt/1.9.3 (2018-01-21)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Guan Xuetao, 

On Wed, Mar 04, 2020 at 06:21:37AM +0530, afzal mohammed wrote:
> request_irq() is preferred over setup_irq(). Invocations of setup_irq()
> occur after memory allocators are ready.
> 
> Per tglx[1], setup_irq() existed in olden days when allocators were not
> ready by the time early interrupts were initialized.
> 
> Hence replace setup_irq() by request_irq().
> 
> [1] https://lkml.kernel.org/r/alpine.DEB.2.20.1710191609480.1971@nanos
> 
> Signed-off-by: afzal mohammed <afzal.mohd.ma@gmail.com>
> ---
> Hi unicorn maintainers,
> 
> if okay w/ this change, please consider taking it thr' your tree, else please
> let me know.

i have not seen any recent pull request from you for unicore32, if
this patch is okay, please consider ack-ing this so as to take via
tglx.

Regards
afzal