Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp1743178ybh; Fri, 13 Mar 2020 06:41:15 -0700 (PDT) X-Google-Smtp-Source: ADFU+vtvS3mkpT0qz5iyimwpesA40p6PrXWDhOlE44vdXWHpYwuGZOZyGbwNLIdqurtPcNBqiK+V X-Received: by 2002:a9d:7d0c:: with SMTP id v12mr11070735otn.171.1584106875085; Fri, 13 Mar 2020 06:41:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584106875; cv=none; d=google.com; s=arc-20160816; b=ZmBvAxXPa4AgEmD1+e2EHhkvLkCW/4NtGEVCX+XDdQJb+SeUA34iKbbdxZyW0Y6hwc B59hzinAz3+d7y4fyRaMGx+UgqPEbGGMr36H7OwFMMVRP6+qoUdC3wCOx+R987DQi+hK 4VtmFllUnaqKBgKlAmS5HSj7eP1yvtXEuSoGyDst7QXTCCDB9WHd4itRMeXITZmXT9xk HeGgbLv3ZfP2sa28P0phQJImy0ovIGNvE37tPYri5LIOY0JKf65mrJ7rqlIH00sz9wkB aYL4XM3uzCdZypOR3hav5Ik6CLYtOTvnO2jNuCcEIhS+5LZNTgj/SMP7rVfoX/iQJxZ1 x4vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=6t790tsVs1tCnJ+Fsf4UobITfMkXmHA/4iUyABTlQh8=; b=UoGpK8SFozpzi2uyjX3an1nmeT32cIawjP6Wyo2AfUoRRzEBxcUt5pjPe2jIVl3BKJ rwD/NVS2UvOtwc6YwA/0iez0HI0JuBNYyqoqsrkNIxPfH96QDTPkr/cd4FL3Z4LzFfwR JPEXfoCMIaoRVmdbaTR67/EKwYPJta9HrQbQRemZIzzzW1WNO/nS69HDqj92GaGZCsa/ CNu6MFAEMgRE6uYa+Wso2iPKTvy0Z/RYxrCRdU+/QmFNlcQ61KoT9Dg/FMdNwDKTHT+P XRFhpkSv2tfgxsoF0dWAXq/pYmzjGjeM5dM9aq+SSHPaFdcsUQDXRjSc4YPz2BJZrLsa Om6w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@synopsys.com header.s=mail header.b="cLQ/sosc"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h203si4508293oif.3.2020.03.13.06.41.02; Fri, 13 Mar 2020 06:41:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@synopsys.com header.s=mail header.b="cLQ/sosc"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726833AbgCMNkM (ORCPT + 99 others); Fri, 13 Mar 2020 09:40:12 -0400 Received: from smtprelay-out1.synopsys.com ([149.117.87.133]:59794 "EHLO smtprelay-out1.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726683AbgCMNkL (ORCPT ); Fri, 13 Mar 2020 09:40:11 -0400 Received: from mailhost.synopsys.com (mdc-mailhost2.synopsys.com [10.225.0.210]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by smtprelay-out1.synopsys.com (Postfix) with ESMTPS id 13428C0FAB; Fri, 13 Mar 2020 13:40:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synopsys.com; s=mail; t=1584106810; bh=E54LODA3Nkm7g3IJUjmzcbT3oFt34YuZSG/e5frmYec=; h=From:To:Cc:Subject:Date:In-Reply-To:References:In-Reply-To: References:From; b=cLQ/soscwtaub51bpfwizsfAwO7XVSBCHOXGVXUI/8JiqkP5X7tNa8VZg7E+b1LB8 PF4nkEsBBO4yQzq3pchbymYiEi36wB23HiQkk/IvRty1a2j6hCDVSIkyWsRcsudE72 Q9RtX9qzkd02px/ehn+BEm+07sUevi0sBHbEnfNg0i1DyVX08Zbf6ZNu+uV+CGwb/E GKdw240JQ7ro4pKv+26yFBu5VaPG7+r3b+PjV36qs+7mMEKa8+EzcfgjmBcdFRh5xy H+ktP/tQT8cZUZiheZeklfjLwtvmm3CyRxJVjE5w++ILaLEvJNzRZjDfkfn1bB6mrY GtulGVW0RodRg== Received: from de02dwia024.internal.synopsys.com (de02dwia024.internal.synopsys.com [10.225.19.81]) by mailhost.synopsys.com (Postfix) with ESMTP id 6DA05A005D; Fri, 13 Mar 2020 13:40:08 +0000 (UTC) From: Jose Abreu To: netdev@vger.kernel.org Cc: Joao Pinto , Jose Abreu , Andrew Lunn , Florian Fainelli , Heiner Kallweit , Russell King , "David S. Miller" , linux-kernel@vger.kernel.org Subject: [PATCH net-next 1/4] net: phy: xpcs: Clear latched value of RX/TX fault Date: Fri, 13 Mar 2020 14:39:40 +0100 Message-Id: <50f3dd2ab58fecfea1156aaf8dbfa99d0c7b36be.1584106347.git.Jose.Abreu@synopsys.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When reading RX/TX fault register we may have latched values from Link down. Clear the latched value first and then read it again to make sure no old errors are flagged and that new errors are caught. Signed-off-by: Jose Abreu --- Cc: Jose Abreu Cc: Andrew Lunn Cc: Florian Fainelli Cc: Heiner Kallweit Cc: Russell King Cc: "David S. Miller" Cc: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- drivers/net/phy/mdio-xpcs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/phy/mdio-xpcs.c b/drivers/net/phy/mdio-xpcs.c index 973f588146f7..a4cbeecc6d42 100644 --- a/drivers/net/phy/mdio-xpcs.c +++ b/drivers/net/phy/mdio-xpcs.c @@ -185,6 +185,7 @@ static int xpcs_read_fault(struct mdio_xpcs_args *xpcs, return -EFAULT; } + xpcs_read(xpcs, MDIO_MMD_PCS, MDIO_STAT2); ret = xpcs_read(xpcs, MDIO_MMD_PCS, MDIO_STAT2); if (ret < 0) return ret; -- 2.7.4