Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp1799466ybh; Fri, 13 Mar 2020 07:37:17 -0700 (PDT) X-Google-Smtp-Source: ADFU+vsrAqNZ+RzC6+QYrk46+v4FS+HNQsKlU81MTU4XO11juHU9jKYWTOzUdzat+YT4Dob5QkeM X-Received: by 2002:a05:6830:10b:: with SMTP id i11mr9259871otp.99.1584110237341; Fri, 13 Mar 2020 07:37:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584110237; cv=none; d=google.com; s=arc-20160816; b=OHHEOvdfI0HIdLC716zHWLxjc0OY/AcJGZZMh8ciBTyS4+f4OI+WZcYP/wSYnMM8eq MYhXmPKhnKzSX3BmPBqaW/V+ZMyLfXTiP3Torm2ULM738C7+y6ySVLxUnR2N1m7rVb4T GabWLpYIIghhSp1TKO2dzNa5sNNx84Tba4Aw3m17SgDkASdcYa+01UaL/NbVb6Re5RW+ JsQO7y4zqNnj+6AQvWLdwOhOL8Z5ufCAO0DvaxU94zbnyYbsaCh8O2/AYw47Xw8Jc8vz VDFc2ihwpxqI/M16wXN3e3Ftp/RL010sceP1ebdXXfXMTYjk+urmOn+i8VK4qALn3Sbl n+3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=WezdpOlVzbaVEs6vfCIvevGk8ide+y5ytNMFt7/McDI=; b=H91l7x6WCdjSwKawXkZ5KLwJ2ZAkjQPGciMcYtaOtdF9N5erbTvFJOk6Ld4pyJaA1D 6QtwFr/XiMMXFMhBYR4ZuykyC3sQJdW6QPx7gnDIujYlaR4p38MfsaJ+dx3e5brcu9yT bgEEA7pSbnA4J2oXVvxsSqLA34Z4nSsT8Z+WhjJAjU+WD2rYpHnxfnoQu7L3124oti4F 1NfqdkSCGaz0S4M2tciPOoEi3zWk077NZwcIw5i/HClLhiWvLVm+k6MSrZyUPHefoWnf ojg70KL2FKXm+U7YcsMiOG2sZ5+OkTboMoYaZDC4yWcw+KyYrMAr/3Hlizdm56GFk5s2 /r2Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=OQiDJfsM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a15si4834936otj.205.2020.03.13.07.37.04; Fri, 13 Mar 2020 07:37:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=OQiDJfsM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726836AbgCMOfg (ORCPT + 99 others); Fri, 13 Mar 2020 10:35:36 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:34181 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726406AbgCMOff (ORCPT ); Fri, 13 Mar 2020 10:35:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584110134; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WezdpOlVzbaVEs6vfCIvevGk8ide+y5ytNMFt7/McDI=; b=OQiDJfsMfXrisXCbzA7Q1mFgNbAFWXWvNRTj8BnzXR/oL7J9TuLlFT9B6oN0PsnaoJNLG5 uDe+wMKHRINU+S4BTeRHTlT10gzwhnbRlvJV+3xyPxiuZ3ZRp8P65HsF7mvL6MjIimRhmM LSqyT7AbFULDGjHHllaABjgy3AJqKPs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-266-2q7-IqrANO65NjR6AP5ocw-1; Fri, 13 Mar 2020 10:35:33 -0400 X-MC-Unique: 2q7-IqrANO65NjR6AP5ocw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AF02E1005509; Fri, 13 Mar 2020 14:35:31 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-116-117.ams2.redhat.com [10.36.116.117]) by smtp.corp.redhat.com (Postfix) with ESMTP id 225AF907F7; Fri, 13 Mar 2020 14:35:31 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 1C1A29DB3; Fri, 13 Mar 2020 15:35:30 +0100 (CET) Date: Fri, 13 Mar 2020 15:35:30 +0100 From: Gerd Hoffmann To: Sam Ravnborg Cc: dri-devel@lists.freedesktop.org, marmarek@invisiblethingslab.com, David Airlie , open list , "open list:DRM DRIVER FOR BOCHS VIRTUAL GPU" Subject: Re: [PATCH v3] drm/bochs: downgrade pci_request_region failure from error to warning Message-ID: <20200313143530.6aoagldak3kpe3xv@sirius.home.kraxel.org> References: <20200313084152.2734-1-kraxel@redhat.com> <20200313090338.GA31815@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200313090338.GA31815@ravnborg.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, > > + if (pci_request_region(pdev, 0, "bochs-drm") != 0) > > + DRM_WARN("Cannot request framebuffer, boot fb still active?\n"); > So you could use drm_WARN() which is what is preferred these days. Nope, this isn't yet in -fixes. cheers, Gerd