Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp1821323ybh; Fri, 13 Mar 2020 08:01:48 -0700 (PDT) X-Google-Smtp-Source: ADFU+vtnQV91M6DFbvrCvELZ5uC0kqpJ9dJwQrLGD5DMYP2kpDM4W8FMX5CSfdIG9PIZxFiad/Qp X-Received: by 2002:aca:4287:: with SMTP id p129mr7056763oia.168.1584111708274; Fri, 13 Mar 2020 08:01:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584111708; cv=none; d=google.com; s=arc-20160816; b=nul5ytQdWQhrmsQsXti4vabZxqf70hf3Waz3QxOeY9IsC9WG5Pi20sJ+bgPdG6kMTQ LWT86racI/7J80AsgYHa5FA8dGwMSpGu4IoIX9raw8cYqDlPaCHGGzbbbJK/ScLDhvNh cb5P/unNR8d/5LSIZbkaWHyaha8ccZWnjfJW1PCv5noZThLmKHwByb2UbwvLf3Ydoq11 oWgQ1HiGzUa/OXIcUshePKb6zlS4yJgVXCpzL42NNVbG1IMqms89lNIFxHztlroIQYlk vk9BR15L2x0Ld4S/Sc+rp/tew/Q/i4/YG60elSvlJUqBj3NbxmKu3vt27OrWeJ7FLTXV 65jA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=4AY9vUoU9N6UJ3dto4LHFzzOPdbOAX5YRu7j/w4t1/A=; b=VxXHn46skOic9DfZV5Pzn2PgxtPoq8LceUWR923vQ27Pf7+o0I6Xe/PORQ5UfFm3rM e+jYTUM2sPH1pwFV5RVK3JD5NfndkZls2zKs9zw6CjHD8h/2ahXN8QlkuE27WCmOf3jl 6t1oYnhuv67zmMD8u0Kg7a7VXTJXlKvatO+EOY5XKtfpnM3d1WBxLMZ1Mj36V3uz21Bq zYw/4z5GFoGvcx6d0KkO8n6TteBDGt3x+1XHkRPZj5FMUhLZbqQiFYa1Tgu68Qb4saB+ SzMERauJUy5GITyqjrYLPaVkf4WpQfgg0IWXGRtPiW7KqxN4Ax9xMprdgMiTyBW4Ufu4 Kq3g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="K8rHC7e/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t25si4887093ott.228.2020.03.13.08.01.25; Fri, 13 Mar 2020 08:01:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="K8rHC7e/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726689AbgCMPBH (ORCPT + 99 others); Fri, 13 Mar 2020 11:01:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:49180 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726528AbgCMPBH (ORCPT ); Fri, 13 Mar 2020 11:01:07 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5AE9A206FA; Fri, 13 Mar 2020 15:01:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584111666; bh=go0P9fgXXPo35byt8AV+LGj/xg18Op3eY2CFhsORJbE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=K8rHC7e/bxxQzKqrId1m+K6LiZKbq8lWuCi+yqYhcaquiz7IwFvkE+RyrH5wmKj+K 3PM2wJT/oiPPYgA904Uke6d4R4y/gv9hly5h282sNqtwBzQ8k2YwnM1AHtyuC1vInn 5AA/nxabwg1lwVt/qWLsvpxMKNnkjPhdQ1La/phw= Date: Fri, 13 Mar 2020 11:01:05 -0400 From: Sasha Levin To: Tim Harvey Cc: Linus Walleij , stable@vger.kernel.org, Robert Richter , Lokesh Vutla , "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] gpio: thunderx: fix irq_request_resources Message-ID: <20200313150105.GF1349@sasha-vm> References: <1583941433-15876-1-git-send-email-tharvey@gateworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 12, 2020 at 10:16:40AM -0700, Tim Harvey wrote: >On Thu, Mar 12, 2020 at 6:42 AM Linus Walleij wrote: >> >> On Wed, Mar 11, 2020 at 4:43 PM Tim Harvey wrote: >> >> > If there are no parent resources do not call irq_chip_request_resources_parent >> > at all as this will return an error. >> > >> > This resolves a regression where devices using a thunderx gpio as an interrupt >> > would fail probing. >> > >> > Fixes: 0d04d0c ("gpio: thunderx: Use the default parent apis for {request,release}_resources") >> > Signed-off-by: Tim Harvey >> >> This patch does not apply to the mainline kernel or v5.6-rc1. >> >> Please verify: >> 1. If the problem is still in v5.6 (we refactored the driver to >> use GPIOLIB_IRQCHIP) > >Linus, > >Sorry, another issue was keeping me from being able to boot 5.6-rc but >that's now understood and I can confirm the issue is not present in >v5.6-rc5 > >> >> 2. If not, only propose it for linux-stable v5.5 etc. >> > >Yes, needs to be applied to v5.2, v5.3, v5.4, v5.5. I cc'd stable. If >I need to re-submit please let me know. > >Cc: stable@vger.kernel.org Linus, could you ack this patch for stable? -- Thanks, Sasha