Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 13 Mar 2020 16:31:52 +0100
From:   Robert Richter <rrichter@marvell.com>
To:     Tim Harvey <tharvey@gateworks.com>
CC:     Linus Walleij <linus.walleij@linaro.org>,
        Lokesh Vutla <lokeshvutla@ti.com>,
        <linux-gpio@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gpio: thunderx: fix irq_request_resources
Message-ID: <20200313153151.e5nmsbr6yrzchdxi@rric.localdomain>
References: <1583941433-15876-1-git-send-email-tharvey@gateworks.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1583941433-15876-1-git-send-email-tharvey@gateworks.com>
User-Agent: NeoMutt/20170113 (1.7.2)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from rric.localdomain (31.208.96.227) by HE1PR0502CA0024.eurprd05.prod.outlook.com (2603:10a6:3:e3::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2793.16 via Frontend Transport; Fri, 13 Mar 2020 15:32:04 +0000
X-Originating-IP: [31.208.96.227]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c2732214-2acd-4e39-7783-08d7c763af6a
X-MS-TrafficTypeDiagnostic: MN2PR18MB3640:
X-Microsoft-Antispam-PRVS: <MN2PR18MB364023519FCD419BBCC384C7D9FA0@MN2PR18MB3640.namprd18.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-Forefront-PRVS: 034119E4F6
X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4636009)(366004)(396003)(136003)(376002)(39860400002)(346002)(199004)(7696005)(52116002)(26005)(66946007)(316002)(53546011)(86362001)(8936002)(186003)(16526019)(66556008)(66476007)(81166006)(81156014)(8676002)(6666004)(956004)(6916009)(6506007)(5660300002)(4326008)(2906002)(55016002)(9686003)(478600001)(54906003)(1076003);DIR:OUT;SFP:1101;SCL:1;SRVR:MN2PR18MB3640;H:MN2PR18MB3408.namprd18.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;
Received-SPF: None (protection.outlook.com: marvell.com does not designate
 permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: D6r3TLRDUgHN4WJL5wA4VVpcaW8ZR9LXdH43Z03KoQ/k4NxxaxIsYTpRV5OdH/RYlbbSrzYd4VEBqAWRSHSYrgSGEqlM1iQ8jNTjIyr0yw+ZvfjpKwI3MggCS+/rpNKHQBh4o0FvDORyp34WTkGlkbI8awQGQlrHL8Wjy22Hd6OHJMrHDWSCJNfdJ9qfpT6A332tJMGujUiG2OrW1mYO2pDc3YYKZ44KGEyqItCoCaNaVBXf75LumR+XI8dKb9eBaYHHp90mv3mua1TCWOt/KMeNDQRnOMPJltoYDHSAvI9Juoh1Gn+6a3qXi0bghmV4PyeiTaUxkpJ6YlWMB0//wiQ99FCHii1fUPA2pYXeSWrmhTtaz7/O+aWu6VY5mnEdqyuKVDG2ojvPkgU17SwCnUvlwzPBXY4AjmEntuh3uAbo8rZaBiSAw7vd7ms80gBQ
X-MS-Exchange-AntiSpam-MessageData: avT6EIrMmqYRP/2RyP5gH+nxZK87sCbMoDNsDuQ7wp5OCd7kkDcr3rUIGH4aEr6LOImgsNpc97Y2qabiCA6oN45FkEaKT4qqS90DoT3M3MCF23zWfDFaCfSFR3VQgLsQr5zmyqNGs9wrK+ajSLPGkQ==
X-MS-Exchange-CrossTenant-Network-Message-Id: c2732214-2acd-4e39-7783-08d7c763af6a
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2020 15:32:05.6533
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nxeQtluK95asE/S9G2qWvq0zESL7mbUJ5guw8ZEQNqNqVpZC5fxzU8mVfsXYLFqzJYnPlnZRZnNMCXPV8E6taA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB3640
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.572
 definitions=2020-03-13_06:2020-03-12,2020-03-13 signatures=0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11.03.20 08:43:53, Tim Harvey wrote:
> If there are no parent resources do not call irq_chip_request_resources_parent
> at all as this will return an error.
> 
> This resolves a regression where devices using a thunderx gpio as an interrupt
> would fail probing.
> 
> Fixes: 0d04d0c ("gpio: thunderx: Use the default parent apis for {request,release}_resources")
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> ---
>  drivers/gpio/gpio-thunderx.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-thunderx.c b/drivers/gpio/gpio-thunderx.c
> index 4627704..f84b9b1 100644
> --- a/drivers/gpio/gpio-thunderx.c
> +++ b/drivers/gpio/gpio-thunderx.c
> @@ -366,15 +366,18 @@ static int thunderx_gpio_irq_request_resources(struct irq_data *data)
>  {
>  	struct thunderx_line *txline = irq_data_get_irq_chip_data(data);
>  	struct thunderx_gpio *txgpio = txline->txgpio;
> +	struct irq_data *parent_data = data->parent_data;
>  	int r;
>  
>  	r = gpiochip_lock_as_irq(&txgpio->chip, txline->line);
>  	if (r)
>  		return r;
>  
> -	r = irq_chip_request_resources_parent(data);
> -	if (r)
> -		gpiochip_unlock_as_irq(&txgpio->chip, txline->line);
> +	if (parent_data && parent_data->chip->irq_request_resources) {
> +		r = irq_chip_request_resources_parent(data);
> +		if (r)
> +			gpiochip_unlock_as_irq(&txgpio->chip, txline->line);
> +	}

There is no unlocking for the else case. I would assume the
parent_data should be checked before grabbing the lock, or is this
intended?

-Robert

>  
>  	return r;
>  }
> -- 
> 2.7.4
>