Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <b623f4a2-8b9b-edd9-3546-281155d90d4a@yandex.ru>
In-Reply-To: <b623f4a2-8b9b-edd9-3546-281155d90d4a@yandex.ru>
From:   Lucas De Marchi <lucas.de.marchi@gmail.com>
Date:   Fri, 13 Mar 2020 09:22:33 -0700
Message-ID: <CAKi4VAK6_vNdh3JYV11TwCDAFCBozaHhUQ-vVWj-hr63B=80HQ@mail.gmail.com>
Subject: Re: [RFE] Who's using a module?
To:     Konstantin Kharlamov <hi-angel@yandex.ru>
Cc:     linux-modules <linux-modules@vger.kernel.org>,
        Jessica Yu <jeyu@kernel.org>,
        lkml <linux-kernel@vger.kernel.org>,
        Steven Rostedt <rostedt@goodmis.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

+Jessica +Steve +lkml

On Wed, Mar 11, 2020 at 6:33 AM Konstantin Kharlamov <hi-angel@yandex.ru> w=
rote:
>
> Once in a while there's a need to remove a module (for example because yo=
u rebuilt it, or to reload it with different parameters, or whatever=E2=80=
=A6). And then doing `rmmod modulename` and `modprobe -r modulename` gives:
>
>         rmmod: ERROR: Module modulename is in use
>
> If you're lucky, firing up `lsmod | grep modulename` will get you offende=
rs inside "used by" column. But often there's nothing except the count abov=
e zero. It is very easy to reproduce if you check `lsmod` output for your g=
raphics driver. I checked it on `i915` and `amdgpu`: when graphics session =
is opened you can't remove it and `lsmod` doesn't show who's using it.
>
> There's very popular and old question on SO=C2=B9 that at the moment has =
over 55k views, and the only answer that seem to work for people is insanel=
y big and convoluted; it is using a custom kernel driver and kernel tracing=
 capabilities. I guess this amount of research means: no, currently there's=
 no easy way to get who's using a module.
>
> It would be amazing if kernel has capability to figure out who's using a =
module.

Yeah, right now this would need some work on the kernel side to record
the callers of try_module_get()/__module_get()... usually done e.g on
fops-like structs in a owner field.
The only thing we have there right now is the trace. The trace is not
so bad since it can be added in the kernel command line, but would
usually only be enabled while debugging.

For implementing such a feature I think we would need to add/remove
module owner into the mod struct whenever we have a _get()/_put().
Maybe it's worth it, but it doesn't
come without overhead. I'd like to hear what other people think.

Thanks
Lucas De Marchi


>
> 1: https://stackoverflow.com/questions/448999/is-there-a-way-to-figure-ou=
t-what-is-using-a-linux-kernel-module
>
> P.S.: please, add me to CC when replying, I'm not subscribed to the list.


--
Lucas De Marchi