Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp1975473ybh; Fri, 13 Mar 2020 10:40:01 -0700 (PDT) X-Google-Smtp-Source: ADFU+vtlcjJJQVpvcjGEyZx8Tz67/Yvpwol9nik7cZ78qNrdm7vft9NMG1T9+mWdDFptaTpoDZ4q X-Received: by 2002:a9d:75c9:: with SMTP id c9mr12768794otl.155.1584121200955; Fri, 13 Mar 2020 10:40:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584121200; cv=none; d=google.com; s=arc-20160816; b=rB/Y4DB3boi4GvCRvWACvJofBTmzGS4NAoJh6LaBg0cXDbqGudOc1sN6PQU9FAqdqH XDQVYFEV5XMu29sEYRH88eVUVZ1jJj9Da/Du3PF6ngGc1CSkvzvtEBd1DCI3lvCtXhhb jPTdT04SCCS0gECnsSwaGmmYn0JL/EENe3GKHSes+eJkZ3I69VVHFcBw4Uq8blX9ftYb vmIaMNl+gCfJdrPx+mLz/RGKvFrUlHzMaPl1bA7+bkbRS7lu5KXxQbWBDd+94zXHYjkF LQ/1B8A322dw0QGumKUzXQT55b9HjQCyOm42geiZ2cmVh453FdC/Nqvg59MqquJ2yGwI 0onQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=R3dyNr4k5uWyS12uYVE6FnBN9I0mOgh5neR4n7Md79s=; b=Q+uZEuR1xcgl0MKdAMjSWU/Vu4froqkvqcrHItSAb1kcOxx5NzDca5Ua4P88a/+Ueb o/Daoj7352ouq1ifhUJM7cK5NNyB88i3IziUwL1J+Kvj1lF9kV2YUyePDD+gOz+vjMp5 qWywDwmPK5VvStG/7xiCT+r7ERfykheBxHTHJi4PX8XtHlUfVRxu0ilwVagh9G5533nL T0JXul7ldXY+1sKo04F1goL3lVDl4j7SJVAyYbEMavYkHnqT3K7HEirZxm4GGDmcxM1F dfK5dhKKf8KepG0rzLOMJH8N+X1ivZXDg2rRKZk45JWlY3wQfV0gKLUwRzruTP840q32 pmUg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ee5U9Uz3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x10si242981oie.211.2020.03.13.10.39.47; Fri, 13 Mar 2020 10:40:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ee5U9Uz3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726702AbgCMRic (ORCPT + 99 others); Fri, 13 Mar 2020 13:38:32 -0400 Received: from mail-ed1-f68.google.com ([209.85.208.68]:40633 "EHLO mail-ed1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726504AbgCMRic (ORCPT ); Fri, 13 Mar 2020 13:38:32 -0400 Received: by mail-ed1-f68.google.com with SMTP id a24so12879373edy.7; Fri, 13 Mar 2020 10:38:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=R3dyNr4k5uWyS12uYVE6FnBN9I0mOgh5neR4n7Md79s=; b=ee5U9Uz3MBtT6Nz8t621V9cJN5wg3+7ZOmT+cjtjz9yVgKB6xgHYYRybpm0tjQ9QFW UGcjiprG0XDeCfpQbAFG3voJF42p6Tz15VbiqWg1ueGEmyyZ1wRpScmPVSclQ1Wo59Cp ig37pPj54xRLrAg5Ne+sMfrmKMbHCRItjmSra80vHh0cwjoHwx0JF00QJDe5Erhe5Kr1 tTLxmCmwU71NpDntU9u6MzMCayInnzI7hiMNZfnfHdJDmESGEqGaMwasHrNoGnvcgC9U EeSrZgB7hscZD4CSfsB8PAdy+S1PbcjEjInySA6+4S0CDDeh7bTQcWiHUb32n41DthI7 Px2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=R3dyNr4k5uWyS12uYVE6FnBN9I0mOgh5neR4n7Md79s=; b=HYmRA4Tf+fjvicCzGBy7c76+m3SwRNDYqPOOcX7R3MzxMf59eg/Yno/w70PQYPUXH+ d0eckgvheyhblmoFe4C/rd/9cpo8atW9dvDCr7bcnPAE7D7m/dpE3DKQayS1rpuGumTb EorfSsMzKgR1ZsfDM3n0rHPc9kF3OEtaIgdYh52WqIefJbk2+IAnIVfyjCntpZK3E9oh PItVbzQm4XYKmoW8KoXG6m3OhhJB+5mrjIAkmGs6n/CiG2ojL9LguUa8qnVC0SmbNR+F bjTh3Uy4ho3cPZHMbInBqop0kJGftwA5dFvoYYYWwcyOG1yOIpT42s5AzN4btXDzey14 FQyw== X-Gm-Message-State: ANhLgQ3VazZR6RuaImf8PHRbKBdnDzKgpyqRkqYEQ/tHJOYVz6vLtGj2 ++EPcO9FAdmLyPr2RuBfH8mvSUDg1qTvR3jisvY= X-Received: by 2002:aa7:de85:: with SMTP id j5mr14292710edv.193.1584121110187; Fri, 13 Mar 2020 10:38:30 -0700 (PDT) MIME-Version: 1.0 References: <20200304005209.5636-1-afzal.mohd.ma@gmail.com> <20200305130843.17989-1-afzal.mohd.ma@gmail.com> <20200313124821.GD7225@afzalpc> In-Reply-To: <20200313124821.GD7225@afzalpc> From: Matt Turner Date: Fri, 13 Mar 2020 10:38:18 -0700 Message-ID: Subject: Re: [PATCH v4] alpha: Replace setup_irq() by request_irq() To: afzal mohammed Cc: Richard Henderson , Ivan Kokshaysky , linux-alpha , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 13, 2020 at 5:48 AM afzal mohammed wrote: > > Hi Richard Henderson, Ivan Kokshaysky, Matt Turner, > > On Thu, Mar 05, 2020 at 06:38:41PM +0530, afzal mohammed wrote: > > request_irq() is preferred over setup_irq(). Invocations of setup_irq() > > occur after memory allocators are ready. > > > > Per tglx[1], setup_irq() existed in olden days when allocators were not > > ready by the time early interrupts were initialized. > > > > Hence replace setup_irq() by request_irq(). > > > > [1] https://lkml.kernel.org/r/alpine.DEB.2.20.1710191609480.1971@nanos > > > > Signed-off-by: afzal mohammed > > If this patch is okay, please consider acking it so as to take it via > tglx. > > Regards > afzal Thanks afzal, Acked-by: Matt Turner