Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp2098337ybh; Fri, 13 Mar 2020 12:49:37 -0700 (PDT) X-Google-Smtp-Source: ADFU+vtq0jtasiAEE8a0lJpD8eeXvgi/Dc4U8s3fIpB37DPoaBmFQwm2mlImEVJd7FRWWa1d0Fmn X-Received: by 2002:aca:4d86:: with SMTP id a128mr8593020oib.96.1584128977694; Fri, 13 Mar 2020 12:49:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584128977; cv=none; d=google.com; s=arc-20160816; b=Z71Sz0MF6g6aI8/5XXZKrM0Z98kpRzWc2KQICN5H8M/JXOtz+UE72UxZ53k37DDEaX zf1YJmZnoEGWFWe95cYoz2yz1dAE4ZTL1uQnCLaJo9LfSgB0DaK76XQsTCXkyyFGBvG0 dLVr8vtxlB1r+1H0HuFi/Vde0uyYyvCIsc0PRRvktEoloM+K1yU+k1XSThvPQwWGIy96 DGOZQEyEow6I+3FZISoFW8SdC7x58BYBChJFD6lAYR6bLl1flEar3Gwfqn7mtWf61qJp j00ZpjOFYXFrA1YV7RMwAAScRsg8yVg0HFujCZjkF8dymRE3UyT7M0AQc0ZabdctJYvU gMPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=qmgIoGWejzvXWqxGx14cXCqtNllXN4PLLRmqrbfXN38=; b=WR7MzcY8EIhYsohzrinBlJPKOf7rfZbXrlIiSrgo8pqgAWJdtsDTFL9Z5C3P2lRKOV bZw/z4ZIEXOjLwn/JkMZ2C04bgt6fPeGTU29RkDKPzpX+XXlTe40mV2vxaKZ2vIk1w18 eK22Vh5ER6bbr8v03HhX3fwDyXFejFYl4CPRBkmkTLdIHorsQ+/vDFM6PY8i9WFzky/q 2t0ATFdXFk/WOuuWrG39iBvjLRSoDZyr7dCsK9dMz5nB0BQFmI6RmnXdUT3bu+bBHime 0NHMPKMcgqh8b+Nugxqygf+kYeQtaJ7p4Ns8+Qpme6V+hdEb0elv3h4pzY853Qqzpxnj MuFA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p25si5202373oto.168.2020.03.13.12.49.25; Fri, 13 Mar 2020 12:49:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727156AbgCMTtH (ORCPT + 99 others); Fri, 13 Mar 2020 15:49:07 -0400 Received: from www62.your-server.de ([213.133.104.62]:43112 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726477AbgCMTtH (ORCPT ); Fri, 13 Mar 2020 15:49:07 -0400 Received: from sslproxy05.your-server.de ([78.46.172.2]) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1jCqIr-0005FL-2P; Fri, 13 Mar 2020 20:49:05 +0100 Received: from [85.7.42.192] (helo=pc-9.home) by sslproxy05.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jCqIq-000FUP-NU; Fri, 13 Mar 2020 20:49:04 +0100 Subject: Re: [PATCH 1/8] bpf: Add missing annotations for __bpf_prog_enter() and __bpf_prog_exit() To: Jules Irenge , boqun.feng@gmail.com Cc: linux-kernel@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, Alexei Starovoitov , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko References: <0/8> <20200311010908.42366-1-jbi.octave@gmail.com> <20200311010908.42366-2-jbi.octave@gmail.com> From: Daniel Borkmann Message-ID: Date: Fri, 13 Mar 2020 20:49:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20200311010908.42366-2-jbi.octave@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.102.2/25750/Fri Mar 13 14:03:09 2020) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/11/20 2:09 AM, Jules Irenge wrote: > Sparse reports a warning at __bpf_prog_enter() and __bpf_prog_exit() > > warning: context imbalance in __bpf_prog_enter() - wrong count at exit > warning: context imbalance in __bpf_prog_exit() - unexpected unlock > > The root cause is the missing annotation at __bpf_prog_enter() > and __bpf_prog_exit() > > Add the missing __acquires(RCU) annotation > Add the missing __releases(RCU) annotation > > Signed-off-by: Jules Irenge Applied this one to bpf-next, thanks!