Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 13 Mar 2020 21:24:44 +0100
From:   Robert Richter <rrichter@marvell.com>
To:     Tim Harvey <tharvey@gateworks.com>
CC:     Linus Walleij <linus.walleij@linaro.org>,
        Lokesh Vutla <lokeshvutla@ti.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gpio: thunderx: fix irq_request_resources
Message-ID: <20200313202444.vdfdowbudlsxmqsf@rric.localdomain>
References: <1583941433-15876-1-git-send-email-tharvey@gateworks.com>
 <20200313153151.e5nmsbr6yrzchdxi@rric.localdomain>
 <20200313191230.qrrlo7ht24fhfhvj@rric.localdomain>
 <CAJ+vNU0q7wW8JPC8FjEkD4a-ZJc1QAmVNne0w1T4MX9pd4bCyg@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJ+vNU0q7wW8JPC8FjEkD4a-ZJc1QAmVNne0w1T4MX9pd4bCyg@mail.gmail.com>
User-Agent: NeoMutt/20170113 (1.7.2)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from rric.localdomain (31.208.96.227) by HE1PR07CA0009.eurprd07.prod.outlook.com (2603:10a6:7:67::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2835.6 via Frontend Transport; Fri, 13 Mar 2020 20:24:50 +0000
X-Originating-IP: [31.208.96.227]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6599e0df-a7d0-49fd-a772-08d7c78c95bc
X-MS-TrafficTypeDiagnostic: MN2PR18MB2878:
X-Microsoft-Antispam-PRVS: <MN2PR18MB28783A716AAA38DB45BAF3FED9FA0@MN2PR18MB2878.namprd18.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-Forefront-PRVS: 034119E4F6
X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4636009)(136003)(39860400002)(346002)(396003)(376002)(366004)(199004)(478600001)(3716004)(2906002)(55016002)(8936002)(54906003)(5660300002)(86362001)(316002)(6916009)(1076003)(7696005)(4326008)(53546011)(6506007)(8676002)(66476007)(6666004)(186003)(66556008)(16526019)(956004)(9686003)(81166006)(66946007)(81156014)(26005)(52116002);DIR:OUT;SFP:1101;SCL:1;SRVR:MN2PR18MB2878;H:MN2PR18MB3408.namprd18.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;
Received-SPF: None (protection.outlook.com: marvell.com does not designate
 permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: oiOM4OFjeX3WMnvrTzGc69GBWwZ/jX6EFlzxzGHbQP3sRuyF1uka02ee6brDb6IXQidLLjXhNt+40M8LMlcdW60N1feVY2HUopCjZ0nedZJuS60oVwBKhIc6sAZfDOJsassSX2U8FPGKdfH9emJtfOeKHjyR2UApoltVA6U6sM4m2y2BixQ6B2d83jYqfCDcoUEqHJLFp/RX1CMKFAeEzkA66JjNhUMEnaJoZtxHxhdA211lekwwHezVjC6ur7q9ew4j3+9TItrarrW3XI3q5ANWY5lynktgS5P/Axg7Fd1AZL7WAJZHwDC2Vj4ALBym/9LQbJEsaTRBXfBhaUiaiaJcGKryIE+y6PxaS12upDVd3hvv8vfla3U8iAjvVHweDsRtWBL8kF8OhusS+nFtdIZ8S+xdFIaRT3IzD1cV9TkrN6BPKLfjRxAMo9HV5cBy
X-MS-Exchange-AntiSpam-MessageData: BGfZMB+7638XqjY2pM1ejtzBwsc8DS85oy/StzTvjLI/9BslNiykK8rCHUsuKByWVB6nDrPI9UM9p36LdamG/wgtcxDNN7gZebvfS2H84lyStUaXJekTgeHLO3Y6HbBOUerpI2d2HNlMcbNSf7b6tA==
X-MS-Exchange-CrossTenant-Network-Message-Id: 6599e0df-a7d0-49fd-a772-08d7c78c95bc
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2020 20:24:52.1140
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eA5LpWrggsF+bMA0MTiWIGl6jY2TjtiirDCsi4e0v9Qp076RfModojlr5tYZhPelwMTkh/wI4Skk6Zs4rk/ECw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2878
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.572
 definitions=2020-03-13_09:2020-03-12,2020-03-13 signatures=0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 13.03.20 12:41:19, Tim Harvey wrote:
> On Fri, Mar 13, 2020 at 12:12 PM Robert Richter <rrichter@marvell.com> wrote:
> >
> > On 13.03.20 16:31:51, Robert Richter wrote:
> > > On 11.03.20 08:43:53, Tim Harvey wrote:
> > > > If there are no parent resources do not call irq_chip_request_resources_parent
> > > > at all as this will return an error.
> > > >
> > > > This resolves a regression where devices using a thunderx gpio as an interrupt
> > > > would fail probing.
> > > >
> > > > Fixes: 0d04d0c ("gpio: thunderx: Use the default parent apis for {request,release}_resources")
> > > > Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> > > > ---
> > > >  drivers/gpio/gpio-thunderx.c | 9 ++++++---
> > > >  1 file changed, 6 insertions(+), 3 deletions(-)

> > Looking at the original code, the parent resources are requested only
> > if existing. So the change is ok.
> >
> > On the other hand, the overall change using irq_chip_{request,
> > release}_resources_parent() became pointless now. It is unreadable and
> > more complex now. Thus, commit 0d04d0c should just be reverted.
> >
> > The function interface is limited. Instead of letting the child device
> > deal with the parent, parent requests should be handled directly in
> > irq_request_resources(). Another aspect is that the code for this
> > driver has been already removed upstream and ti_sci_inta_msi.c is the
> > last remaining user of it. This speaks also for a removal by a revert.

> A revert does make the most sense to me and it works for 5.2, 5.3, and
> 5.5 but the revert fails for 5.4 and needs some manual intervention.

v5.4 should additionally revert a7fc89f9d5fc ("gpio: thunderx: Switch
to GPIOLIB_IRQCHIP"). v5.5 contains this revert too (a564ac35d605
Revert "gpio: thunderx: Switch to GPIOLIB_IRQCHIP") and the code in
that area is the same then for all kernels from 5.2 to 5.5, which is
basically a revert back to 5.1. I think this is ok.

Do you have a particular test case to test the driver that I can use
for my own testing?

Thanks,

-Robert