Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp2183842ybh; Fri, 13 Mar 2020 14:27:39 -0700 (PDT) X-Google-Smtp-Source: ADFU+vsoUxZcCOn3xMnpj1sGrkAKd74QH22koTRHoGIbeeDp7yOlf1H8/YPZSwyKkjevDTyWrL0v X-Received: by 2002:aca:5ad5:: with SMTP id o204mr8356363oib.2.1584134858971; Fri, 13 Mar 2020 14:27:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584134858; cv=none; d=google.com; s=arc-20160816; b=f07iLE/M17PwmZVRRrPSzd6iZ9IQXrejbpC9De+P+qbQtyw8b15D3wISD0BoaeAkQM WEd328uuY+WTX6BeJmEfV3IqE6JUjOo8+EnMYUfyo1eke8t9TeJ/1fL2q2TCOSUwsdnN QwfypszAasA2kNELXnDEJZ6sGRYj/G6Y72kTBGbIRqvYH3fGtUjF+t1Gt77EahedAOwg bOyx9seEO6Sxr3Fg54x571uES4NiMslFjf5Od8TlRVRdJkA9EHXLB4WeVF2bQZdAe+Hu 2t1/FvPXtY8tQhNP1vwc2USM1sE5hL7Az4cdIS3SWhjtM3f9Xo3LrUfqtS02n49eCTSU HqHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=6G8s1T+GZ3P8r3F6F1F/EpnEULgc6g/30mc+g7rqZr4=; b=FJJkF6fDhZ3MIbGU9mX+wSc+U6G5UaN2s3Tga6QXuPtRRM+3j6CTvRS7YEckOXRFNv DfT8SngTPhm97+NQOenJloele6qyc4VPULtP6pxh476XrCfjO4pSGkkTXxZbbwJCPi6T vcefYJIrJUdXxIt38vIxi/5QRfT3vk935xiETe/ctsSl8fiCke4xAP9S8s5vWifzkuEH v8AD7RBsmP44+PTDNYZCHLbRdbGnFwoOWnXVJ8ves4ieh6cuU79afv78PyUaxCSzHtKw O2/xtpr22eoQihGOSvhWdWnK86O69xJ6n6Tj6qgyoiVQ+DPn9IOXT7fZQmUiLC9C6SAa NpGQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=Ba9ga6dt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y8si5370236otq.122.2020.03.13.14.27.26; Fri, 13 Mar 2020 14:27:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=Ba9ga6dt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727282AbgCMV0j (ORCPT + 99 others); Fri, 13 Mar 2020 17:26:39 -0400 Received: from merlin.infradead.org ([205.233.59.134]:52798 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726526AbgCMV0j (ORCPT ); Fri, 13 Mar 2020 17:26:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=6G8s1T+GZ3P8r3F6F1F/EpnEULgc6g/30mc+g7rqZr4=; b=Ba9ga6dttaNNgbz+Sr5soV2Ykr RueY7hooO5ZKBSibZK2CL1EkMwUHTFU3rE9DCCNrITWjH3eB42Rf76AFanuK5uHe11ov4EEpivTmK KCDFZ9pla/p21BZxZpuOkUoe6rdM7Xh5w6x6HH91cru7jMLX9e1Du7PdO6R89hDdk0wtZGdONguiT Q+ExgRY804XZKESZFyuO1i4twz/7kNSwsYWslC1xWQqFyB5Yykr0yj5Oumx8Ato1pj3gyi2HdgdPY j6DrQeHQlQzvBjdt4kj3hVWMaiOjJr1mhunoLQjivT1Qg2xijTOivBDHghjYKp7vc5dFwoZYO6Pay dyTsFVBg==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=worktop.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jCrp1-00072l-6x; Fri, 13 Mar 2020 21:26:23 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id 241CE98112D; Fri, 13 Mar 2020 22:26:20 +0100 (CET) Date: Fri, 13 Mar 2020 22:26:20 +0100 From: Peter Zijlstra To: Qian Cai Cc: Thomas Gleixner , John Stultz , sboyd@kernel.org, rostedt@goodmis.org, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, Andy Lutomirski Subject: Re: [PATCH] timer: silenct a lockdep splat with debugobjects Message-ID: <20200313212620.GA2452@worktop.programming.kicks-ass.net> References: <20200313154221.1566-1-cai@lca.pw> <20200313180811.GD12521@hirez.programming.kicks-ass.net> <4FFD109D-EAC1-486F-8548-AA1F5E024120@lca.pw> <20200313201314.GE5086@worktop.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 13, 2020 at 05:00:41PM -0400, Qian Cai wrote: > > On Mar 13, 2020, at 4:13 PM, Peter Zijlstra wrote: > > > > Or, fix that random crud to do the wakeup outside of the lock. > > That is likely to be difficult until we can find a creative way to not “uglifying" the > random code by dropping locks in the middle etc just because of debugojects. https://git.kernel.org/pub/scm/linux/kernel/git/luto/linux.git/log/?h=random/fast Doesn't look difficult at all.