Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Rafael J. Wysocki" <rjw@rjwysocki.net>
To:     Alexey Dobriyan <adobriyan@gmail.com>
Cc:     lenb@kernel.org, tglx@linutronix.de, mingo@redhat.com,
        bp@alien8.de, hpa@zytor.com, luto@kernel.org, x86@kernel.org,
        linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH] x86/acpi: make "asmlinkage" part first thing in the function definition
Date:   Sat, 14 Mar 2020 10:33:31 +0100
Message-ID: <1684981.ixsy79CQbx@kreacher>
In-Reply-To: <20200303204144.GA9913@avx2>
References: <20200303204144.GA9913@avx2>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tuesday, March 3, 2020 9:41:44 PM CET Alexey Dobriyan wrote:
> g++ insists that function declaration must start with extern "C"
> (which asmlinkage expands to).
> 
> gcc doesn't care.
> 
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
> 
>  arch/x86/kernel/acpi/sleep.c |    2 +-
>  arch/x86/kernel/acpi/sleep.h |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> --- a/arch/x86/kernel/acpi/sleep.c
> +++ b/arch/x86/kernel/acpi/sleep.c
> @@ -43,7 +43,7 @@ unsigned long acpi_get_wakeup_address(void)
>   *
>   * Wrapper around acpi_enter_sleep_state() to be called by assmebly.
>   */
> -acpi_status asmlinkage __visible x86_acpi_enter_sleep_state(u8 state)
> +asmlinkage acpi_status __visible x86_acpi_enter_sleep_state(u8 state)
>  {
>  	return acpi_enter_sleep_state(state);
>  }
> --- a/arch/x86/kernel/acpi/sleep.h
> +++ b/arch/x86/kernel/acpi/sleep.h
> @@ -19,4 +19,4 @@ extern void do_suspend_lowlevel(void);
>  
>  extern int x86_acpi_suspend_lowlevel(void);
>  
> -acpi_status asmlinkage x86_acpi_enter_sleep_state(u8 state);
> +asmlinkage acpi_status x86_acpi_enter_sleep_state(u8 state);
> 

Applied as 5.7 material, thanks!