Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp1123812ybh; Sat, 14 Mar 2020 18:42:02 -0700 (PDT) X-Google-Smtp-Source: ADFU+vumsWSL6mULYpqp81Lg5mYBS8GYiTPbYRrZf7zQnp1rQu709l/WP+FplOnie2wkgb9QOsDM X-Received: by 2002:aca:3008:: with SMTP id w8mr12133982oiw.96.1584236522658; Sat, 14 Mar 2020 18:42:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584236522; cv=none; d=google.com; s=arc-20160816; b=AbMT5eIE04ztrwvcHs1U8VvcxcDtCjNRdldafnsZdPCZXxfcd92YlX3RLKjW1dgViM 2nMbjKtMbGk6GlOAuzkk4+8fhi+5Dsy7Eet1bg4JOumZbkpwSEenwAQRNlZyid3gi3kL A0tRtk4VfCvR+EF6w/CoF5Gqve9a68cEqR2+VR1CsZChrO6XtHCIy+KkNI/83PFTKjAx 1T9r++KCo5DhPlec0n2YJYbAuqRxGReFgmPPHBxx8PrfYNY6TNjfRJHM3Qdj9XvIy0Qs 1FIrSxVi8lHCFGkTKRfzvDw1kEm8Uo8xikVtghXWkg8I1oeyiPIzmi/Ndd9+4OzjTwqB oQkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject:dkim-signature; bh=+/247cTfFPmb6HzvLpP0YBhAOHansbCR7qRIbohrXkI=; b=NXfGE0JAGfWHgcGscIpGipGkrVZtTpK+5q2n5TAk8xmJgtb7IjV4enCwXHXGv3Uw+7 P+J9r0RQ2YY6GUimIG+mZ2at2Yni6E2K7k/Lb1ryAxv9lskwioyuZHygFncGbAzTrFL0 ySTEToWnNo0z7LhRNtP12CyLsvfhIjwTj3TrD5IK0yzbDpjyrD4ULLXR95+rGJ39QkE1 A784tZ0qH/z86lH+iUgMRkyRz3E3p1Dzn58Lpf19zLkqUfWOG9mRx1g03RCgK4F+eHe5 my042UjZrNsP/AkRRNyLzjynKMoh6krs3ekk4SjYFPyTd7U4cFxlhckGlD5LCoZvmh3B 5p7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b="E/h3JWyS"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n198si7056067oig.37.2020.03.14.18.41.51; Sat, 14 Mar 2020 18:42:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b="E/h3JWyS"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726922AbgCOBlW (ORCPT + 99 others); Sat, 14 Mar 2020 21:41:22 -0400 Received: from mail-io1-f65.google.com ([209.85.166.65]:35551 "EHLO mail-io1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726530AbgCOBlV (ORCPT ); Sat, 14 Mar 2020 21:41:21 -0400 Received: by mail-io1-f65.google.com with SMTP id h8so13635511iob.2 for ; Sat, 14 Mar 2020 18:41:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=+/247cTfFPmb6HzvLpP0YBhAOHansbCR7qRIbohrXkI=; b=E/h3JWySV60dxpGI2gxROTmY2mZeLVVOoioeXtEAq5DSRgyFBnAaTzBmVeIOUJNDYl pUNhavjej7XYrSfD7CWWOuCQN17b3T9dPhuBnfOH76BnRFd+wRSYWOVsmliAt0etk6gg DYJ9Nv8nF8GNuZpxgUZhrLeusJaLQzZk3lUmayLRYGH1E/E/grkRjfJTS3je8tzmbuNT Ys2H/0GpAbMCnru4/QcjKJ9ceya9viY3VelMvPMhmkU80VYVbvQPyyt1+sCejng8cLnA uCL0+aT+3hLuQZPQ2jhC27DjOTakBFMCjqAPDGe7DidgAz3Dl9rvTVjknDflOsLeEvbr IbhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+/247cTfFPmb6HzvLpP0YBhAOHansbCR7qRIbohrXkI=; b=dPJO5Hq3FLcKnaVVluSZYcJh2jDlnFNPDNQeLxrLY6OHHYgov5r8iKNlQ2AueMvEpp w7U144MaxYdcmT1Cc1qkBgRpcqAnyG9rQATcIK8PEw5it4MJzVbemJhi4rj91CBUlduv Gr6y8eL6GKq211ShAR/UVmjro2CivfPQe9Y+eWVEE68e2TNcMqSVfeba3i68QQLGoWpk QSL3BLGebjF7BPua3Ny8MX/ZsonXtKJF/l5p1UIDICycaJS4degXicbOsTAsZ7sjxcMy hJWSlu5QK8gfyRn9te/z6pG1EFb/7D7OfY5CAuLAMnj6fvOcHZWhPLCpGF6j2oiuZpIa H71w== X-Gm-Message-State: ANhLgQ0F5MHmrMu2W2KAwFfps01xJuCyQrvW8H9dFZWah6jTV8Ry82fL EtC5o9j0QVzH/xkZfIyNMZ+a9RHoNnr9uA== X-Received: by 2002:a63:8b42:: with SMTP id j63mr19006128pge.27.1584226866175; Sat, 14 Mar 2020 16:01:06 -0700 (PDT) Received: from [192.168.1.188] ([66.219.217.145]) by smtp.gmail.com with ESMTPSA id g6sm12179905pjv.13.2020.03.14.16.01.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 14 Mar 2020 16:01:05 -0700 (PDT) Subject: Re: [PATCH 5.6] io_uring: NULL-deref for IOSQE_{ASYNC,DRAIN} To: Pavel Begunkov , io-uring@vger.kernel.org, linux-kernel@vger.kernel.org References: <3fff749b19ae1c3c2d59e88462a8a5bfc9e6689f.1584127615.git.asml.silence@gmail.com> <6ebc5e8a-7a6c-2537-9050-fe4e5c4f014d@gmail.com> From: Jens Axboe Message-ID: Date: Sat, 14 Mar 2020 17:01:03 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <6ebc5e8a-7a6c-2537-9050-fe4e5c4f014d@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/13/20 3:29 PM, Pavel Begunkov wrote: > On 13/03/2020 23:28, Pavel Begunkov wrote: >> Hmm, found unreliably failing the across-fork test. I don't know whether it's >> this patch specific, but need to take a look there first. > > It's good to go, just used outdated tests. > The reproducer is attached. I integrated this into the existing read-write in liburing, thanks. -- Jens Axboe