Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] kernel/hung_task.c: Introduce sysctl to print all traces
 when a hung task is detected
To:     Kees Cook <keescook@chromium.org>,
        "Guilherme G. Piccoli" <gpiccoli@canonical.com>
Cc:     linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        linux-doc@vger.kernel.org, mcgrof@kernel.org, yzaikin@google.com,
        tglx@linutronix.de, kernel@gpiccoli.net
References: <20200310155650.17968-1-gpiccoli@canonical.com>
 <ef3b3e9a-9d58-60ec-d638-88ad57d29aec@canonical.com>
 <202003132011.8143A71FE@keescook>
From:   Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Message-ID: <c4b05b32-216a-e130-259f-0d9506ff9244@i-love.sakura.ne.jp>
Date:   Sat, 14 Mar 2020 13:27:13 +0900
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.5.0
MIME-Version: 1.0
In-Reply-To: <202003132011.8143A71FE@keescook>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2020/03/14 12:12, Kees Cook wrote:
> On Fri, Mar 13, 2020 at 02:23:37PM -0300, Guilherme G. Piccoli wrote:
>> Kees / Testsuo, are you OK with this patch once I resend with the
>> suggestions you gave me?
> 
> I think so, yes. Send a v2 (to akpm with us in CC).
> 
>> Is there anybody else I should loop in the patch that should take a
>> look? Never sent sysctl stuff before, sorry if I forgot somebody heheh
> 
> akpm usually takes these kinds of things.
> 

Well, maybe sysctl_hung_task_all_cpu_backtrace = 1 by default is better for
compatibility? Please CC or BCC kernel-testing people so that they can add
hung_task_all_cpu_backtrace=1 kernel command line parameter to their testing
environments if sysctl_hung_task_all_cpu_backtrace = 0 by default.