Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 15 Mar 2020 14:11:38 +0000 (UTC)
From:   Christopher Lameter <cl@linux.com>
To:     Kees Cook <keescook@chromium.org>
cc:     David Laight <David.Laight@ACULAB.COM>,
        Andrew Morton <akpm@linux-foundation.org>,
        Pekka Enberg <penberg@kernel.org>,
        David Rientjes <rientjes@google.com>,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>,
        Daniel Micay <danielmicay@gmail.com>,
        Vitaly Nikolenko <vnik@duasynt.com>,
        Silvio Cesare <silvio.cesare@gmail.com>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] slub: Relocate freelist pointer to middle of object
In-Reply-To: <202003111039.24B8A0B@keescook>
Message-ID: <alpine.DEB.2.21.2003151410220.14449@www.lameter.com>
References: <202003051624.AAAC9AECC@keescook> <alpine.DEB.2.21.2003081919290.14266@www.lameter.com> <6fbf67b5936a44feaf9ad5b58d39082b@AcuMS.aculab.com> <202003111039.24B8A0B@keescook>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 11 Mar 2020, Kees Cook wrote:

> > Sounds good. You could even randomize the position to avoid attacks on via
> > the freelist pointer.
>
> That's a good point. "offset" is just calculated once, and for many
> slabs, the available space is quite large. I wonder what the best

Correct.

> practice might be for how far from the edge to stay. Hmmm. Maybe simply
> carve it into thirds, and randomize the offset within the middle third?

Take off the first and last word and randomize within the space that is
left?