Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <5e6e4954.1c69fb81.f5a45.b76d@mx.google.com>
Date:   Sun, 15 Mar 2020 20:57:13 +0530
From:   Rohit Sarkar <rohitsarkar5398@gmail.com>
To:     Jonathan Cameron <jic23@kernel.org>
Cc:     linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
        alexandru.Ardelean@analog.com, dragos.bogdan@analog.com,
        Matt Ranostay <matt.ranostay@konsulko.com>
Subject: Re: [PATCH] iio: health: max30100: use generic property handler
References: <5e6afe0d.1c69fb81.25912.f2eb@mx.google.com>
 <20200315124955.207d515c@archlinux>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200315124955.207d515c@archlinux>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, Mar 15, 2020 at 12:50:39PM +0000, Jonathan Cameron wrote:
> On Fri, 13 Mar 2020 08:59:13 +0530
> Rohit Sarkar <rohitsarkar5398@gmail.com> wrote:
> 
> > Instead of of_property_read_xxx use device_property_read_xxx as it is
> > compatible with ACPI too as opposed to only device tree.
> > 
> > Signed-off-by: Rohit Sarkar <rohitsarkar5398@gmail.com>
> 
> Look at how this driver is probing from DT.  There is another thing you need
> to do to make it possible to use PRP001 ACPI based bindings.
> 
> (check what Andy Shevchenko did in a similar patch)
> 
> I'm being deliberately vague as useful for you to understand what is going
> on here for yourself :)
> 
> Also, make sure to check you have cc'd everyone relevant.  Here you are missing
> the driver author. +cc Matt
> Jonathan

Have sent out a v2 with the required correction, although I still dont completely
understand how this ACPI magic works. In the process of going over 
https://www.kernel.org/doc/Documentation/acpi/enumeration.txt get a
better picture.

Thanks,
Rohit